cephadm: show error during bootstrap if private registry cred not provided #45589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adk3798
reviewed
Mar 23, 2022
melissa-kun-li
force-pushed
the
bootstrap_registry_warning
branch
2 times, most recently
from
0b3cc21
to
5c38b42
Compare
adk3798
reviewed
Mar 30, 2022
melissa-kun-li
force-pushed
the
bootstrap_registry_warning
branch
2 times, most recently
from
ab66ce0
to
672773a
Compare
adk3798
reviewed
Apr 8, 2022
Raise UnauthorizedRegistryError in `_pull_image` if user tries to pull from a private registry without authentication, handle error in `command_bootstrap`, `commond_adopt`, `command_pull` Fixes: https://tracker.ceph.com/issues/55015 Signed-off-by: Melissa Li <melissali@redhat.com>
melissa-kun-li
force-pushed
the
bootstrap_registry_warning
branch
from
672773a
to
4de0803
Compare
|
jenkins test make check |
adk3798
approved these changes
Apr 8, 2022
|
2 failures: 1 caused by https://tracker.ceph.com/issues/49287 |
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise UnauthorizedRegistryError in
_pull_imageif user tries to pull from a private registry without authentication, handle error incommand_bootstrap,commond_adopt,command_pullFixes: https://tracker.ceph.com/issues/55015
Signed-off-by: Melissa Li melissali@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows