pacific: osd/PrimaryLogPG.cc: CEPH_OSD_OP_OMAPRMKEYRANGE should mark omap dirty #45591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should mark_omap_dirty() for all omap write ops, just like we did in cb92792. Currently, for CEPH_OSD_OP_OMAPRMKEYRANGE ops, clean_omap gets set to true, which results in incomplete recovery of objects and results in inconsistent PGs after a scrub. Fixes: https://tracker.ceph.com/issues/54592 Signed-off-by: Neha Ojha <nojha@redhat.com> (cherry picked from commit f7fd589)
neha-ojha
approved these changes
Mar 23, 2022
ronen-fr
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should mark_omap_dirty() for all omap write ops, just like we did
in cb92792.
Currently, for CEPH_OSD_OP_OMAPRMKEYRANGE ops, clean_omap gets set to true,
which results in incomplete recovery of objects and results in
inconsistent PGs after a scrub.
Fixes: https://tracker.ceph.com/issues/54592
Signed-off-by: Neha Ojha nojha@redhat.com
(cherry picked from commit f7fd589)
Backport Tracker: https://tracker.ceph.com/issues/55020