Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix api test issue with pip #45647

Merged
merged 1 commit into from
Mar 28, 2022
Merged

mgr/dashboard: fix api test issue with pip #45647

merged 1 commit into from
Mar 28, 2022

Conversation

epuertat
Copy link
Member

@epuertat epuertat commented Mar 25, 2022 •
edited

Fix

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-libcloud 3.5.0 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible.
Successfully installed CherryPy-13.1.0 PyJWT-2.0.1 Routes-2.4.1 bcrypt-3.1.4 ceph-1.0.0 chardet-4.0.0 cheroot-8.6.0 idna-2.10 jaraco.functools-3.5.0 more-itertools-4.1.0 natsort-8.1.0 portend-3.1.0 pyopenssl-22.0.0 pytz-2022.1 repoze.lru-0.7 requests-2.25.1 tempora-5.0.1

Fixes: https://tracker.ceph.com/issues/55060
Signed-off-by: Ernesto Puerta epuertat@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@epuertat epuertat requested a review from a team as a code owner March 25, 2022 15:27
@epuertat epuertat requested review from avanthakkar and Sarthak0702 and removed request for a team March 25, 2022 15:27
@epuertat epuertat requested review from djgalloway and zmc March 25, 2022 15:28
@djgalloway
Copy link

Are we not worrying about the apache-libcloud 3.5.0 requires requests>=2.26.0 message? Maybe I'm misunderstanding but won't requests~=2.25 install any requests 2.25.X version but not 2.26?

@djgalloway djgalloway mentioned this pull request Mar 25, 2022
Merged
zmc
zmc previously requested changes Mar 25, 2022
View reviewed changes
src/pybind/mgr/dashboard/constraints.txt Outdated Show resolved Hide resolved
@idryomov idryomov mentioned this pull request Mar 25, 2022
Merged
@epuertat
Copy link
Member Author

Are we not worrying about the apache-libcloud 3.5.0 requires requests>=2.26.0 message? Maybe I'm misunderstanding but won't requests~=2.25 install any requests 2.25.X version but not 2.26?

@djgalloway requests~=2.25 is soft-pinning to anything between requests>=2.25 and requests<3, so that basically leaves up to the pip resolver to choose the version based on the requirements from other packages (2.26 in this very case). We started doing this hard-pinning to stick to the CentOS and OpenSUSE package versions (python3-requests-2.20 for CentOS 8 and the 2.25 came perhaps from OpenSUSE).

@epuertat
mgr/dashboard: fix api test issue with pip
2289ad2 
Fix
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-libcloud 3.5.0 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible.
Successfully installed CherryPy-13.1.0 PyJWT-2.0.1 Routes-2.4.1 bcrypt-3.1.4 ceph-1.0.0 chardet-4.0.0 cheroot-8.6.0 idna-2.10 jaraco.functools-3.5.0 more-itertools-4.1.0 natsort-8.1.0 portend-3.1.0 pyopenssl-22.0.0 pytz-2022.1 repoze.lru-0.7 requests-2.25.1 tempora-5.0.1
```

Fixes: https://tracker.ceph.com/issues/55060
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
@github-actions github-actions bot added this to In progress in Dashboard Mar 28, 2022
@epuertat epuertat requested a review from zmc March 28, 2022 09:30
@aaSharma14
Copy link
Contributor

jenkins test make check

Dashboard automation moved this from In progress to Reviewer approved Mar 28, 2022
@epuertat epuertat merged commit 2022a56 into ceph:master Mar 28, 2022
Dashboard automation moved this from Reviewer approved to Done Mar 28, 2022
@epuertat epuertat deleted the fix-55060-master branch March 28, 2022 15:29
@epuertat
Copy link
Member Author

Let's have this merged with 1 approval (+1 addressing changes requested by @zmc) since this might block all PRs.

This was referenced Apr 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@avanthakkar avanthakkar Awaiting requested review from avanthakkar avanthakkar was automatically assigned from ceph/dashboard

@Sarthak0702 Sarthak0702 Awaiting requested review from Sarthak0702 Sarthak0702 was automatically assigned from ceph/dashboard

@djgalloway djgalloway Awaiting requested review from djgalloway

@zmc zmc Awaiting requested review from zmc

Assignees
No one assigned
Labels
bug-fix dashboard pybind tests
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
4 participants
@epuertat @djgalloway @aaSharma14 @zmc