Quincy: fast shutdown backports #45653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osd_fast_shutdown_notify_mon option is false by default. So users suffer from error log flood, slow ops, and the long I/O timeouts on voluntary OS shutdown before they are aware of the existence of this option. Let's make this option true by default. Fixes: https://tracker.ceph.com/issues/53328 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com> (cherry picked from commit 729a5b8)
When osd_fast_shutdown and osd_fast_shutdown_notify_mon set as true, OSD marked as Down it should be marked as Dead, Fixed: https://tracker.ceph.com/issues/53327 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com> nd nd (cherry picked from commit 07302d5)
Modify test_activate_osd() to get the type of scheduler in use and then verify the value of osd_max_backfills. This is because mclock scheduler overrides this option to 1000 upon OSD initialization. The test earlier used to pass because the OSD daemon was killed but not marked down and upon being brought up, the wait for OSD up check was passing quickly. But the OSD still didn't have the latest config values. But now upon killing the OSD, the osd_fast_shutdown sequence notifies the mon (see PR: ceph#44807) and is marked down and dead. Upon bringing it up, the wait for OSD up check takes a longer time and this is sufficient for the config values to be updated. This results in the correct values being read from the config 'Values' map. Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com> (cherry picked from commit 3aa2df2)
neha-ojha
approved these changes
Mar 25, 2022
neha-ojha
changed the title
|
Should be merged after #45651 |
sseshasa
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44807 and #45651.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows