os/BlueStore: NCB fix for SimpleBitmap boundary check #45733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boundary check in SimpleBitmap is off by one causing an assert to trigger Also fixed a bug when asking for the next clear_extent on a unaligned map when the last bits in the map were set. Adding unit-tests Fixes: https://tracker.ceph.com/issues/55145 Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>
benhanokh
force-pushed
the
simple_bitmap_fix
branch
from
01ba970
to
7dfa208
Compare
aclamk
approved these changes
Mar 31, 2022
| SimpleBitmap sbmap(g_ceph_context, bit_count); | ||
|
|
||
| sbmap.set(0, bit_count); | ||
| ASSERT_TRUE(sbmap.get_next_set_extent(0) == full_extent); |
There was a problem hiding this comment.
TIP:
ASSERT_EQ(sbmap.get_next_set_extent(0), full_extent)
also works once operator== is defined.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boundary check in SimpleBitmap is off by one causing an assert to trigger
Fixes: https://tracker.ceph.com/issues/55145
Signed-off-by: Gabriel BenHanokh gbenhano@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows