rgw: change default ops log backend from rados to file

[cbodley]

a proposed change to the default backend when rgw_enable_ops_log is enabled, based on discussion in #45691

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[mattbenjamin]

lgtm

[cbodley]

note that i copied this from the log_file option which defaults to /var/log/ceph/$cluster-$name.log

[cbodley]

@cfsnyder i'd like to add a blurb about log rotation for rgw_ops_log_file_path. can you summarize how cephadm does this, or point me at docs maybe?

[cfsnyder]

Yeah sure @cbodley. cephadm automatically adds logrotate config on the host for all files matching /var/log/ceph/{fsid}/*.log. So if the rgw_ops_log_file_path config param matches /var/log/ceph/*.log (container path), it'll be handled by the cephadm config.

Here's an example of the config it generated on one of my test clusters:

root@ceph01:~# cat /etc/logrotate.d/ceph-74016538-b125-11ec-abb9-3daf21fa986b 
# created by cephadm
/var/log/ceph/74016538-b125-11ec-abb9-3daf21fa986b/*.log {
    rotate 7
    daily
    compress
    sharedscripts
    postrotate
        chown 167:167 /var/log/ceph/74016538-b125-11ec-abb9-3daf21fa986b/*.log; killall -q -1 ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw rbd-mirror cephfs-mirror || pkill -1 -x 'ceph-mon|ceph-mgr|ceph-mds|ceph-osd|ceph-fuse|radosgw|rbd-mirror|cephfs-mirror' || true
    endscript
    missingok
    notifempty
    su root root
}

As you can see, it rotates daily and keeps 7 days of compressed logs.

[cbodley]

that's great, thanks

[cbodley]

hmm

[ RUN      ] TestRGWLua.OpsLog
unix socket connect error: 2
../src/test/rgw/test_rgw_lua.cc:682: Failure
Value of: unix_socket_client_ended_ok
  Actual: false
Expected: true
[  FAILED  ] TestRGWLua.OpsLog (8808 ms)

[cbodley]

passed qa in https://pulpito.ceph.com/cbodley-2022-04-26_01:02:21-rgw-wip-cbodley-testing-distro-default-smithi/, but depends on the fixes in #46027 so we'll need to merge that first

[cfsnyder]

Nice!