Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: mgr/telemetry: anonymize daemons in telemetry perf_counters #45857

Merged
merged 3 commits into from Apr 12, 2022
Merged

quincy: mgr/telemetry: anonymize daemons in telemetry perf_counters #45857

merged 3 commits into from Apr 12, 2022

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented Apr 11, 2022 •
edited

backport tracker: https://tracker.ceph.com/issues/55269

backport of #45819
parent tracker: https://tracker.ceph.com/issues/55229

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

ljflores and others added 3 commits April 11, 2022 17:06
@ljflores
mgr/telemetry: anonymize daemons in telemetry perf_counters
0f4e546 
In the telemetry perf channel we collect 'perf_counters' of individual daemons.
The monitors appear with their full name, which includes the host name.
The host name part must be anonymized.

To err on the safe side, I have anonymized all daemons except for osds,
since they are not attached to host names.

Fixes: https://tracker.ceph.com/issues/55229
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 0fe47b9)
@yaarith @ljflores
mgr/telemetry: add anonymize_entity_name function
3d44f2d 
The ability to anonymize entity names should have its own function
to prevent duplicate code.
Will clean up in a separate commit.

Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
(cherry picked from commit e89d821)
@yaarith @ljflores
mgr/telemetry: fix daemon anonymization in perf_counters
c1736e6 
Anonymized daemons now appear with a SHA1 digest instead of their
original identifier, e.g.:

    "perf_counters": {
        "mon.1b1b829ba9298527f4934053a4742a1710937007": {
            "mon": {
                "election_call": {
                    "value": 1
                },
                ...
                "session_trim": {
                    "value": 0
                }
            },
        ...
        }
    ...
    }

Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
(cherry picked from commit 2f4cc77)
@ljflores ljflores requested a review from yaarith April 11, 2022 17:10
@github-actions github-actions bot added this to the quincy milestone Apr 11, 2022
@ljflores ljflores added backport: no-conflicts Backport without conflicts and removed pybind labels Apr 11, 2022
@ljflores
Copy link
Contributor Author

jenkins test docs

@ljflores
Copy link
Contributor Author

jenkins render docs

@ljflores
Copy link
Contributor Author

http://pulpito.front.sepia.ceph.com/yuriw-2022-04-11_21:21:54-rados-wip-yuri11-testing-2022-04-11-1138-quincy-distro-default-smithi/
http://pulpito.front.sepia.ceph.com/yuriw-2022-04-12_15:27:11-rados-wip-yuri11-testing-2022-04-11-1138-quincy-distro-default-smithi/

Failures, unrelated:
https://tracker.ceph.com/issues/52124

Details:
1. Invalid read of size 8 in handle_recovery_delete() - Ceph - RADOS

@neha-ojha neha-ojha removed the DNM label Apr 12, 2022
@yuriw yuriw merged commit cdb037c into ceph:quincy Apr 12, 2022
@ljflores ljflores deleted the wip-quincy-55269 branch April 12, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaarith yaarith yaarith approved these changes

Assignees
No one assigned
Labels
backport: no-conflicts Backport without conflicts needs-qa telemetry wip-yuri11-testing
Projects
None yet
Milestone
quincy
4 participants
@ljflores @yaarith @yuriw @neha-ojha