Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard/frontend: fix cypress env password #45915

Merged
merged 1 commit into from Apr 16, 2022
Merged

mgr/dashboard/frontend: fix cypress env password #45915

merged 1 commit into from Apr 16, 2022

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented Apr 15, 2022 •
edited

"LOGIN_PASSWORD" should be "LOGIN_PWD". Bug introduced in e9128c4.

Fixes: https://tracker.ceph.com/issues/55323
Signed-off-by: Laura Flores lflores@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@ljflores
mgr/dashboard/frontend: fix cypress env password
cf6feab 
"LOGIN_PASSWORD" should be "LOGIN_PWD". Bug introduced
in e9128c4.

Fixes: https://tracker.ceph.com/issues/55323
Signed-off-by: Laura Flores <lflores@redhat.com>
@ljflores ljflores requested a review from a team as a code owner April 15, 2022 22:16
@ljflores ljflores requested review from aaSharma14 and removed request for a team April 15, 2022 22:16
@ljflores
Copy link
Contributor Author

ljflores commented Apr 15, 2022 •
edited

@Sarthak0702 see if this change makes sense to you.

Before (affected Dashboard e2e tests):
http://pulpito.front.sepia.ceph.com/yuriw-2022-04-13_20:41:44-rados-wip-yuri2-testing-2022-04-13-0703-distro-default-smithi/

After (all green):
http://pulpito.front.sepia.ceph.com/lflores-2022-04-15_00:31:23-rados-wip-dashboard-cypress-password-distro-default-smithi/

@Sarthak0702
Copy link
Member

Sarthak0702 commented Apr 15, 2022 •
edited

@Sarthak0702 see if this change makes sense to you.

Before (affected Dashboard e2e tests): http://pulpito.front.sepia.ceph.com/yuriw-2022-04-13_20:41:44-rados-wip-yuri2-testing-2022-04-13-0703-distro-default-smithi/

After (all green): http://pulpito.front.sepia.ceph.com/lflores-2022-04-15_00:31:23-rados-wip-dashboard-cypress-password-distro-default-smithi/

Yup that's correct! Thanks for this @ljflores . Lets get it merged quickly.

@ljflores
Copy link
Contributor Author

Yup that's correct! Thanks for this @ljflores . Lets get it merged quickly.

Cool, teuthology tests passed (namely the e2e tests), so I'll merge it.

@ljflores ljflores merged commit c1b0ecc into ceph:master Apr 16, 2022
@ljflores ljflores deleted the wip-dashboard-cypress-password branch April 17, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sarthak0702 Sarthak0702 Sarthak0702 approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14 aaSharma14 was automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
dashboard pybind
Projects
None yet
Milestone
No milestone
2 participants
@ljflores @Sarthak0702