New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix a blocklist API test #46010
Conversation
Otherwise, our grep fails! Fixes: https://tracker.ceph.com/issues/55419 Signed-off-by: Greg Farnum <gfarnum@redhat.com>
This is entirely untested as a fix because I can't figure out how to run the cephtool test locally just yet, but from log inspection this is the issue. |
@ljflores you reported this; don't suppose you know how to run individual tests like this locally? Otherwise I guess I'll spin up a small suite run that invokes it. |
@gregsfortytwo yeah, there's a way we can rerun the exact test that it originally failed. I can look into doing that on Monday. |
jenkins test make check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on one of Yuri's qa runs, where the cephtool test failed. Re-running that branch with the suite repo set to this branch passed all the cephtool tests:
The make check failure is a recent regression. See more details here: #43413 (comment) |
jenkins test make check |
@neha-ojha this test passed when run against Yuri's master branch (wip-yuri2-testing-2022-04-22-0500). Would you say that's thorough enough, or should this go through the whole rados suite? |
This is enough. |
This test case was added in #44151, but I screwed up and did less testing on that PR than I thought I had before merging. :/
Fixes: https://tracker.ceph.com/issues/55419
Signed-off-by: Greg Farnum gfarnum@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows