mgr/dashboard: rbd striping setting pre-population and pop-over #46014

vrushch · 2022-04-24T20:46:26Z

Pre-populating the stripe count to 1 (now it's empty). "1" means no "fancy striping", anything else enables the fancy striping.
Adding a pop-over explaining each setting for striping (object size, stripe unit and stripe count).

New default value to 1

New helper explaining the RBD striping features

Fixes: https://tracker.ceph.com/issues/39726
Signed-off-by: Vrushal Chaudhari vrushalcs@gmail.com

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

nizamial09

Thank you! @vrushch

You need to fix the make-check error though

[lint:html    ] src/app/ceph/block/rbd-form/rbd-form.component.html: line 282, col NaN, Tabs not allowed
[lint:html    ] src/app/ceph/block/rbd-form/rbd-form.component.html: line 307, col NaN, Tabs not allowed
[lint:html    ] 
[lint:html    ] [htmllint] found 2 errors out of 163 files
[lint:tslint  ] TSLint's support is discontinued and we're deprecating its support in Angular CLI.
[lint:tslint  ] To opt-in using the community driven ESLint builder, see: https://github.com/angular-eslint/angular-eslint#migrating-an-angular-cli-project-from-codelyzer-and-tslint.
[lint:prettier] src/app/ceph/block/rbd-form/rbd-form.component.ts
[lint:tslint  ] Linting "ceph-dashboard"...
[lint:tslint  ] All files pass linting.

Try running 'npm run fix' to fix some linting errors. Some errors might need a manual fix.

npm run fix should solve that.

nizamial09 · 2022-04-25T17:49:33Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.html

@@ -262,7 +262,7 @@
            <div class="form-group row">
              <label i18n
                     class="cd-col-form-label"
-                     for="size">Object size</label>
+                     for="size">Object size<cd-helper>Object Size: Objects in the Ceph Storage Cluster have a maximum configurable size (e.g., 2MB, 4MB, etc.). The object size should be large enough to accommodate many stripe units, and should be a multiple of the stripe unit.</cd-helper></label>


Emphasizing on some of the important words and making it bold will make it easier for someone to read it better I think

Hi @nizamial09 ,
I have fixed the linting issue now. will check about making some important words bold in pop-over

vrushch · 2022-04-26T10:38:49Z

Hi @epuertat ,
Now as we are pre-populating Stripe Count to 1. This makes the selection of Stripe Unit compulsory. (we are currently not pre-populating Stripe Unit field).
From User perspective this means, everytime user wants to create a RBD, user will need to click on Advanced and select Stripe Unit.

I tried creating RBD with different size without this PR, I observed Stripe Unit defaults to 4 MiB when Stripe Count is not given.
should I make change to pre-populate Stripe Unit to 4MiB?

epuertat · 2022-05-10T16:48:59Z

Hi @epuertat , Now as we are pre-populating Stripe Count to 1. This makes the selection of Stripe Unit compulsory. (we are currently not pre-populating Stripe Unit field). From User perspective this means, everytime user wants to create a RBD, user will need to click on Advanced and select Stripe Unit.

I tried creating RBD with different size without this PR, I observed Stripe Unit defaults to 4 MiB when Stripe Count is not given. should I make change to pre-populate Stripe Unit to 4MiB?

Hi @vrushch, I tested this and it looks nice (I added a few screenshots to the PR description).

Yes, we need to ensure that the RBD image can be created without the user opening the Advanced section. In fact, now when a user clicks "Create" nothing happens and the user doesn't receive any feedback (unless they expand the Advanced section).

So yes, if we preset the striping size to 1, we need also to ensure that we provide defaults for the other fields.

epuertat

Thanks a lot for this contribution, @vrushch ! It's almost ready to be merged, but it needs first to deal with the stripe unit issue, and I left some suggestions for improvement on the helper messages.

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.html

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.ts

vrushch · 2022-05-10T17:51:54Z

Hi @epuertat ,
I have pushed changes to remove redundant information in pop-over at all 3 places.
for stripe unit issue, I have made stripe unit value default to 4 MiB. (referenced It by creating number of RBD's with different sizes while keeping Object Size to default 4 MiB , Everytime stripe unit got set to 4 MiB)

Please review and suggest changes if any.
Thanks again for taking time to review and giving review comments

github-actions · 2022-06-07T16:12:45Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

nizamial09 · 2022-06-13T09:13:05Z

@vrushch could you please rebase the PR, thanks

Pre-populating the stripe count to 1 (now it's empty). "1" means no "fancy striping", anything else enables the fancy striping. Adding a pop-over explaining each setting for striping (object size, stripe unit and stripe count). Fixes: https://tracker.ceph.com/issues/39726 Signed-off-by: Vrushal Chaudhari <vrushalcs@gmail.com>

epuertat

LGTM! Thank you @vrushch for your contribution here!

pereman2 · 2022-07-13T12:25:06Z

jenkins test dashboard

pereman2 · 2022-07-13T12:25:16Z

jenkins test dashboard cephadm

pereman2 · 2022-07-14T09:29:48Z

jenkins test dashboard cephadm

vrushch requested a review from a team as a code owner April 24, 2022 20:46

vrushch requested review from avanthakkar and epuertat and removed request for a team April 24, 2022 20:46

github-actions bot added dashboard pybind labels Apr 24, 2022

epuertat added this to In progress in Dashboard via automation Apr 25, 2022

epuertat added the GSoC / Outreachy label Apr 25, 2022

nizamial09 approved these changes Apr 25, 2022

View reviewed changes

Dashboard automation moved this from In progress to Reviewer approved Apr 25, 2022

vrushch force-pushed the rbd_form_fix branch from 6c2547f to dd887bc Compare April 26, 2022 10:28

epuertat requested changes May 10, 2022

View reviewed changes

Dashboard automation moved this from Reviewer approved to Review in progress May 10, 2022

vrushch force-pushed the rbd_form_fix branch from dd887bc to 93e79c9 Compare May 10, 2022 17:43

djgalloway changed the base branch from master to main May 25, 2022 20:00

github-actions bot added the needs-rebase label Jun 7, 2022

nizamial09 assigned Pegonzal Jun 29, 2022

Pegonzal force-pushed the rbd_form_fix branch from 93e79c9 to 52dc04c Compare June 29, 2022 14:31

github-actions bot removed the needs-rebase label Jun 29, 2022

epuertat approved these changes Jun 30, 2022

View reviewed changes

Dashboard automation moved this from Review in progress to Reviewer approved Jun 30, 2022

pereman2 moved this from Reviewer approved to Ready-to-merge in Dashboard Jul 14, 2022

pereman2 merged commit 45ecfc6 into ceph:main Jul 14, 2022

Dashboard automation moved this from Ready-to-merge to Done Jul 14, 2022

This was referenced Aug 2, 2022

quincy: mgr/dashboard: rbd striping setting pre-population and pop-over #47409

Merged

pacific: mgr/dashboard: rbd striping setting pre-population and pop-over #47410

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard: rbd striping setting pre-population and pop-over #46014

mgr/dashboard: rbd striping setting pre-population and pop-over #46014

vrushch commented Apr 24, 2022 •

edited by pereman2

nizamial09 left a comment

nizamial09 Apr 25, 2022

vrushch Apr 27, 2022

vrushch commented Apr 26, 2022

epuertat commented May 10, 2022

epuertat left a comment

vrushch commented May 10, 2022

github-actions bot commented Jun 7, 2022

nizamial09 commented Jun 13, 2022

epuertat left a comment

pereman2 commented Jul 13, 2022

pereman2 commented Jul 13, 2022

pereman2 commented Jul 14, 2022

mgr/dashboard: rbd striping setting pre-population and pop-over #46014

mgr/dashboard: rbd striping setting pre-population and pop-over #46014

Conversation

vrushch commented Apr 24, 2022 • edited by pereman2

New default value to 1

New helper explaining the RBD striping features

Checklist

nizamial09 left a comment

Choose a reason for hiding this comment

nizamial09 Apr 25, 2022

Choose a reason for hiding this comment

vrushch Apr 27, 2022

Choose a reason for hiding this comment

vrushch commented Apr 26, 2022

epuertat commented May 10, 2022

epuertat left a comment

Choose a reason for hiding this comment

vrushch commented May 10, 2022

github-actions bot commented Jun 7, 2022

nizamial09 commented Jun 13, 2022

epuertat left a comment

Choose a reason for hiding this comment

pereman2 commented Jul 13, 2022

pereman2 commented Jul 13, 2022

pereman2 commented Jul 14, 2022

vrushch commented Apr 24, 2022 •

edited by pereman2