pacific: rgw: Avoid segfault when OPA authz is enabled #46106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitKnecht
requested review from
pereman2 and
nizamial09
and removed request for
a team
|
looks like this needs a rebase |
|
@BenoitKnecht please rebase so there's only the single commit from #45873 on top of the current pacific branch. this currently includes lots of merge commits and other unrelated changes |
When `rgw_use_opa_authz=true`, radosgw would segfault on any request that didn't target a specific object or bucket, because `s->object` or `s->bucket` would be `nullptr` in that case, but that code path would try to dereference them anyway. This commit only adds the `object_name`, `subuser`, `user_info` and `bucket_info` JSON objects if the corresponding `s->X` object is defined, thereby avoiding segfaults in radosgw when Open Policy Agent authorization is enabled. Fixes: https://tracker.ceph.com/issues/55286 Signed-off-by: Benoît Knecht <bknecht@protonmail.ch> (cherry picked from commit ac71916)
BenoitKnecht
force-pushed
the
wip-55500-pacific
branch
from
c0fb749
to
3cecb88
Compare
|
@cbodley Done. |
cbodley
requested review from
a team
and removed request for
a team,
pereman2 and
nizamial09
smanjara
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/55500
backport of #45873
parent tracker: https://tracker.ceph.com/issues/55286
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh