os/bluestore: fix empty store divide by 0 runtime error #46133
Conversation
Fixes runtime error ../src/os/bluestore/BlueStore.cc:4364:7: runtime error: inf is outside the range of representable values of type 'unsigned long' Fixes: https://tracker.ceph.com/issues/55325 Signed-off-by: Samuel Just <sjust@redhat.com>
|
jenkins test make check |
|
@aclamk Does this look ok? |
| @@ -2460,7 +2460,8 @@ class BlueStore : public ObjectStore, | |||
| return (2 > onode_num) ? 2 : onode_num; | |||
| } | |||
| double get_bytes_per_onode() const { | |||
| return (double)_get_used_bytes() / (double)_get_num_onodes(); | |||
| return std::max((double)_get_used_bytes(), 1.0) / | |||
There was a problem hiding this comment.
Looks like std::max should be applied to _get_num_onodes() call not _get_used_bytes() to fight devision by zero issue
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows