Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: use swap for deferred_stable when not bluefs_layout.single_shared_device() #46225

Merged
merged 1 commit into from Jul 8, 2022

Conversation

inspur-wyq
Copy link
Contributor

@inspur-wyq inspur-wyq commented May 11, 2022

When bluefs_layout.single_shared_device() is false and deferred_done is not empty, the deferred_stable_queue is always empty which make deferred_stable empty also.
So we can use swap instead of insert when insert key of deferred_done to deferred_stable.

Signed-off-by: wangyunqing wangyunqing@inspur.com

Fixes: https://tracker.ceph.com/issues/55608

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@inspur-wyq inspur-wyq force-pushed the wip-bluestore-deferred_stable branch 2 times, most recently from 271ac1a to 5337f33 Compare May 11, 2022 08:52
…gle_shared_device()

Fixes: https://tracker.ceph.com/issues/55608

When `bluefs_layout.single_shared_device()` is false and `deferred_done` is not empty, the `deferred_stable_queue` is always empty which make `deferred_stable` empty also.
So we can use swap instead of insert when insert key of `deferred_done` to `deferred_stable`.

Signed-off-by: wangyunqing <wangyunqing@inspur.com>
@inspur-wyq inspur-wyq force-pushed the wip-bluestore-deferred_stable branch from 5337f33 to 234d1c8 Compare May 11, 2022 08:58
@djgalloway djgalloway changed the base branch from master to main May 25, 2022 19:59
@ifed01
Copy link
Contributor

ifed01 commented Jun 13, 2022

jenkins test make check

@ifed01
Copy link
Contributor

ifed01 commented Jun 13, 2022

jenkins test make check arm64

1 similar comment
@ifed01
Copy link
Contributor

ifed01 commented Jun 13, 2022

jenkins test make check arm64

@sseshasa
Copy link
Contributor

sseshasa commented Jul 7, 2022

Teuthology Test Result
https://pulpito.ceph.com/yuriw-2022-06-27_15:15:17-rados-wip-yuri2-testing-2022-06-24-1331-distro-default-smithi
https://pulpito.ceph.com/?branch=wip-yuri2-testing-2022-06-29-0820

Unrelated Failures

  1. Failure Reason: Valgrind failures in mon and osd.
    Existing Trackers: https://tracker.ceph.com/issues/52124 and https://tracker.ceph.com/issues/54603

  2. Failure Reason: 'wait for operator' reached maximum tries (90) after waiting for 900 seconds
    Existing tracker: https://tracker.ceph.com/issues/52420

  3. Failure Reason: "2022-06-30T02:07:39.827451+0000 mon.a (mon.0) 142 : cluster [WRN] Health check failed: Degraded data redundancy: 2/4 objects degraded (50.000%), 1 pg degraded (PG_DEGRADED)" in cluster log
    Existing Tracker: https://tracker.ceph.com/issues/51282

  4. Failure Reason: Exiting scrub checking -- not all pgs scrubbed
    Existing Tracker: https://tracker.ceph.com/issues/53342

  5. Failure Reason: mgr get_metadata_python Requested missing service mon.a
    Existing Tracker: https://tracker.ceph.com/issues/55322

  6. Failure Reason: Tests cls_rgw.index_list and cls_rgw.index_list_delimited failed in qa/workunits/cls/test_cls_rgw.sh
    Existing Tracker: https://tracker.ceph.com/issues/55853

  7. Failure Reason: "2022-06-30T04:02:32.040193+0000 osd.3 (osd.3) 33 : cluster [ERR] osd.3(0) found snap mapper error on pg 3.bs0> oid 3:d81a0fb3:::smithi10749189-30:137 snaps missing in mapper, should be: 132,137 ...repaired" in cluster log
    Existing Tracker: https://tracker.ceph.com/issues/49525 was fixed, but this is reappearing again.
    Raised New Tracker: https://tracker.ceph.com/issues/56438

  8. Failure Reason: Command failed on smithi080 with status 123: "find /home/ubuntu/cephtest/archive/syslog -name '*.log' -print0 | sudo xargs -0 --no-run-if-empty -- gzip --"
    Existing Tracker: https://tracker.ceph.com/issues/50868

@yuriw
Copy link
Contributor

yuriw commented Jul 7, 2022

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented Jul 7, 2022

jenkins test this please

@yuriw yuriw merged commit aaac999 into ceph:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants