New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/bluestore: use swap for deferred_stable when not bluefs_layout.single_shared_device() #46225
Conversation
271ac1a
to
5337f33
Compare
…gle_shared_device() Fixes: https://tracker.ceph.com/issues/55608 When `bluefs_layout.single_shared_device()` is false and `deferred_done` is not empty, the `deferred_stable_queue` is always empty which make `deferred_stable` empty also. So we can use swap instead of insert when insert key of `deferred_done` to `deferred_stable`. Signed-off-by: wangyunqing <wangyunqing@inspur.com>
5337f33
to
234d1c8
Compare
jenkins test make check |
jenkins test make check arm64 |
1 similar comment
jenkins test make check arm64 |
Teuthology Test Result Unrelated Failures
|
jenkins test make check |
jenkins test this please |
When
bluefs_layout.single_shared_device()
is false anddeferred_done
is not empty, thedeferred_stable_queue
is always empty which makedeferred_stable
empty also.So we can use swap instead of insert when insert key of
deferred_done
todeferred_stable
.Signed-off-by: wangyunqing wangyunqing@inspur.com
Fixes: https://tracker.ceph.com/issues/55608
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows