Hammer uclient checking #4629
Merged
Hammer uclient checking #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit 3c4028e) Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Just because it's easier to read. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 289ee3b) Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Previously, on an error such as a pool not existing, the caller doing the check would error out, but anyone waiting on waiting_for_pool_perm would block indefinitely (symptom was that reads on a file with a bogus layout would block forever). Fix by triggering the wait list on errors and clear the CHECKING state so that the other callers also perform the check and find the error. Additionally, don't return the RADOS error code up to filesystem users, because it can be misleading. For example, nonexistent pool is ENOENT, but we shouldn't give ENOENT on IO to a file which does exist, we should give EIO. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit e08cf25) Reviewed-by: Greg Farnum <gfarnum@redhat.com>
|
We don't normally do backports of FS features, but this one prevents us from running into an ObjectCacher bug that isn't exposed via librbd and for which the fixing patch is in the middle of a fairly big series. |
|
http://pulpito.ceph.com/loic-2015-05-09_11:11:23-fs-hammer-uclient-checking-testing-basic-multi/ ./virtualenv/bin/teuthology-suite --priority 101 --suite fs -k testing --suite-branch hammer --machine-type plana,burnupi,mira --distro ubuntu --email greg@gregs42.com --ceph hammer-uclient-checking it that completes successfully, feel free to merge before QE starts testing (that will be announced on ceph-devel, probably monday) and it will be in v0.94.2 |
ghost
pushed a commit
that referenced
this pull request
May 11, 2015
Hammer uclient checking Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the new preemptive pool permission checking.
Fixes: #11510.