New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: object creation by write cannot use an offset on an erasure coded pool #4632

Merged
1 commit merged into from Jul 21, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented May 9, 2015

osd: refuse to write a new erasure coded object with an offset > 0
Even if the offset is properly aligned.

http://tracker.ceph.com/issues/11507 Fixes: #11507

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit a4f1256)

@ghost ghost added bug fix core labels May 10, 2015

@ghost ghost added this to the firefly milestone May 10, 2015

@ghost ghost self-assigned this May 10, 2015

@ghost ghost assigned smithfarm and unassigned ghost Jun 2, 2015

@ghost ghost changed the title from object creation by write cannot use an offset on an erasure coded pool to osd: object creation by write cannot use an offset on an erasure coded pool Jul 21, 2015

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

this is a border case for which there is a test case in master. The test case was not backported and none of the integration / unit test run into this specific situation therefore there is no actual proof that it works. The http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi successfull run only shows that it did not disrupt anything obvious. Given the nature of the modification and the fact that it tested successfully in master, it can be merged without further testing. The erasure code alignment constraints and the requirements did not change between firefly and hammer.

ghost pushed a commit that referenced this pull request Jul 21, 2015

Loic Dachary
Merge pull request #4632 from SUSE/wip-11507-firefly
osd: object creation by write cannot use an offset on an erasure coded pool

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 8638443 into ceph:firefly Jul 21, 2015

@smithfarm smithfarm deleted the SUSE:wip-11507-firefly branch Jul 21, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment