Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: stop polling when page is not visible #46370

Merged
merged 1 commit into from Jun 14, 2022
Merged

mgr/dashboard: stop polling when page is not visible #46370

merged 1 commit into from Jun 14, 2022

Conversation

Sarthak0702
Copy link
Member

@Sarthak0702 Sarthak0702 commented May 23, 2022 •
edited

Uses custom RxJS operator whenPageVisible (from here) to achieve this.

Fixes: https://tracker.ceph.com/issues/50963
Signed-off-by: Sarthak0702 sarthak.dev.0702@gmail.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Sarthak0702 Sarthak0702 requested a review from a team as a code owner May 23, 2022 16:02
@Sarthak0702 Sarthak0702 requested review from avanthakkar and epuertat and removed request for a team May 23, 2022 16:02
@Sarthak0702 Sarthak0702 added this to In progress in Dashboard via automation May 23, 2022
@Sarthak0702
Copy link
Member Author

jenkins test dashboard cephadm

@Sarthak0702
Copy link
Member Author

jenkins test dashboard

@djgalloway djgalloway changed the base branch from master to main May 25, 2022 19:57
@Sarthak0702
Copy link
Member Author

jenkins retest this please

@Sarthak0702
Copy link
Member Author

jenkins test dashboard cephadm

epuertat
epuertat approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The cd-datatable component has its own polling. Have you checked if it's too complicate to include this there too?

I checked and it works with tab swtiching and minimizing the browser, but not when another app overlaps the browser 🤔

Dashboard automation moved this from In progress to Reviewer approved May 30, 2022
@epuertat epuertat removed the request for review from aaSharma14 June 3, 2022 09:20
@Sarthak0702 Sarthak0702 force-pushed the stop-poll-page-inactive branch 2 times, most recently from e065547 to 5dd69fa Compare June 5, 2022 08:07
@Sarthak0702 Sarthak0702 force-pushed the stop-poll-page-inactive branch 2 times, most recently from 5696949 to f967727 Compare June 8, 2022 07:33
avanthakkar
avanthakkar approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts Show resolved Hide resolved
@Sarthak0702 Sarthak0702 moved this from Reviewer approved to Ready-to-merge in Dashboard Jun 8, 2022
@Sarthak0702
Copy link
Member Author

jenkins test make check

1 similar comment
@avanthakkar
Copy link
Contributor

jenkins test make check

@Sarthak0702
mgr/dashboard: stop polling when page is not visible
fa8a62f 
Signed-off-by: Sarthak0702 <sarthak.dev.0702@gmail.com>
@Sarthak0702
Copy link
Member Author

jenkins test make check

@Sarthak0702
Copy link
Member Author

jenkins test dashboard

@Sarthak0702
Copy link
Member Author

jenkins test dashboard cephadm

@Sarthak0702
Copy link
Member Author

The ceph dashboard cephadm e2e tests failure is unrelated to this PR and is known issue. @epuertat this can be merged.

@epuertat epuertat merged commit 9a527b3 into ceph:main Jun 14, 2022
Dashboard automation moved this from Ready-to-merge to Done Jun 14, 2022
@epuertat epuertat deleted the stop-poll-page-inactive branch June 14, 2022 11:24
This was referenced Jun 14, 2022
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epuertat epuertat epuertat approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

Assignees
No one assigned
Labels
dashboard pybind ready-to-merge
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
3 participants
@Sarthak0702 @avanthakkar @epuertat