Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd #46428

Merged
merged 1 commit into from
Jun 14, 2022

Commits on May 30, 2022

  1. mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new"…

    … cmd
    
    Before proceeding to handle "osd new" mon command as part of
    OSDMonitor::prepare_command_impl(), a check is made to verify if the
    authmon is writeable. Later on, prepare_command_osd_new() invokes
    KVMonitor::do_osd_new() to create pending dmcrypt keys and calls
    propose_pending(). The propose could fail (with an assertion failure)
    if there was a prior mon command that resulted in the kvmon invoking
    propose_pending().
    
    In order to avoid such a situation, introduce a check to verify that
    kvmon is also writeable in OSDMonitor::prepare_command_impl(). If it
    is not writeable, the op is pushed into the wait_for_active context
    queue to be retried later.
    
    Fixes: https://tracker.ceph.com/issues/55773
    Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
    sseshasa committed May 30, 2022
    Configuration menu
    Copy the full SHA
    9a0d42c View commit details
    Browse the repository at this point in the history