Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: add rbd primary info #46479

Merged
merged 1 commit into from Jun 7, 2022

Conversation

pereman2
Copy link
Contributor

@pereman2 pereman2 commented Jun 1, 2022

Fixes: https://tracker.ceph.com/issues/55912
Signed-off-by: Pere Diaz Bou pdiazbou@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@pereman2 pereman2 requested a review from a team as a code owner June 1, 2022 10:45
@pereman2 pereman2 added this to In progress in Dashboard via automation Jun 1, 2022
@pereman2 pereman2 requested review from nSedrickm and aaSharma14 and removed request for a team June 1, 2022 10:45
Dashboard automation moved this from In progress to Reviewer approved Jun 1, 2022
@pereman2 pereman2 moved this from Reviewer approved to Ready-to-merge in Dashboard Jun 2, 2022
@epuertat
Copy link
Member

epuertat commented Jun 2, 2022

@pereman2 related API failure:

2022-06-01 11:25:14,994.994 INFO:__main__:----------------------------------------------------------------------
2022-06-01 11:25:14,994.994 INFO:__main__:Traceback (most recent call last):
2022-06-01 11:25:14,994.994 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 481, in assertSchema
2022-06-01 11:25:14,994.994 INFO:__main__:    return _validate_json(data, schema)
2022-06-01 11:25:14,994.994 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 708, in _validate_json
2022-06-01 11:25:14,994.994 INFO:__main__:    raise _ValError('unknown keys: {}'.format(unknown_keys), path)
2022-06-01 11:25:14,994.994 INFO:__main__:tasks.mgr.dashboard.helper._ValError: In `input`: unknown keys: {'primary'}
2022-06-01 11:25:14,995.995 INFO:__main__:
2022-06-01 11:25:14,995.995 INFO:__main__:During handling of the above exception, another exception occurred:
2022-06-01 11:25:14,995.995 INFO:__main__:
2022-06-01 11:25:14,995.995 INFO:__main__:Traceback (most recent call last):
2022-06-01 11:25:14,995.995 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/test_rbd.py", line 672, in test_clone
2022-06-01 11:25:14,995.995 INFO:__main__:    self._validate_image(img, features_name=['exclusive-lock',
2022-06-01 11:25:14,995.995 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/test_rbd.py", line 249, in _validate_image
2022-06-01 11:25:14,995.995 INFO:__main__:    self.assertSchema(img, schema)
2022-06-01 11:25:14,995.995 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 483, in assertSchema
2022-06-01 11:25:14,995.995 INFO:__main__:    self.assertEqual(data, str(e))
2022-06-01 11:25:14,995.995 INFO:__main__:AssertionError: {'size': 1073741824, 'obj_size': 4194304,[6011 chars] 0}]} != "In `input`: unknown keys: {'primary'}"
2022-06-01 11:25:14,995.995 INFO:__main__:
Cannot find device "ceph-brx"
2022-06-01 11:25:15,020.020 INFO:__main__:
2022-06-01 11:25:15,020.020 INFO:__main__:----------------------------------------------------------------------
2022-06-01 11:25:15,020.020 INFO:__main__:

@epuertat epuertat moved this from Ready-to-merge to Reviewer approved in Dashboard Jun 2, 2022
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
@pereman2 pereman2 force-pushed the rbd-mirroring-list-primary branch from 4332a65 to 578ee21 Compare June 6, 2022 04:43
@github-actions github-actions bot added the tests label Jun 6, 2022
@Sarthak0702 Sarthak0702 self-requested a review June 6, 2022 16:30
Copy link
Member

@Sarthak0702 Sarthak0702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pereman2 pereman2 moved this from Reviewer approved to Ready-to-merge in Dashboard Jun 7, 2022
@pereman2 pereman2 merged commit e3062db into ceph:main Jun 7, 2022
Dashboard automation moved this from Ready-to-merge to Done Jun 7, 2022
@pereman2 pereman2 deleted the rbd-mirroring-list-primary branch June 7, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
3 participants