pybind/mgr/cephadm/upgrade: allow upgrades without reducing max_mds

[dparmar18]

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[dparmar18]

Commits have been kept like this just for the sake of clarity on what I've been doing around the PR. Will squash them once the reviews are done.

[dparmar18]

jenkins test make check

[batrick]

Code looks about right. This now needs QA tests in fs:upgrade.

[dparmar18]

jenkins test make check

[github-actions]

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

[kotreshhr]

@dparmar18 You should remove the draft status by marking 'Ready for review' if it is so.

[dparmar18]

@dparmar18 You should remove the draft status by marking 'Ready for review' if it is so.

Yeah, I'm waiting for something to pass, I'll definitely mark it as 'Ready for review' soon.

[anthonyeleven]

Yeah, I'm waiting for something to pass, I'll definitely mark it as 'Ready for review' soon.

Still a make check failure :-/ Might be a good time to squash the commits too.

[dparmar18]

I was experimenting with some workarounds and thus used multiple branches for the purpose. Rebasing this PR with those changes might bring some conflicts that need resolution therefore decided to open a new PR - #47092 and close this one.