ceph-detect-init: plain setup.py install on make install #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no DESTDIR environment variable is set, just python setup.py install instead of setting --root, --prefix or --install-layout. These options are tested to do the right thing in the context of RPM and deb packaging but they are presumably not what someone using make install manually would want. http://tracker.ceph.com/issues/11598 Fixes: #11598 Signed-off-by: Loic Dachary <ldachary@redhat.com>
ghost
added
the
ghost
pushed a commit
that referenced
this pull request
May 13, 2015
ceph-detect-init: plain setup.py install on make install Reviewed-by: Kernel Neophyte <neophyte.hacker001@gmail.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no DESTDIR environment variable is set, just
python setup.py install
instead of setting --root, --prefix or --install-layout. These options
are tested to do the right thing in the context of RPM and deb packaging
but they are presumably not what someone using make install manually
would want.
http://tracker.ceph.com/issues/11598 Fixes: #11598
Signed-off-by: Loic Dachary ldachary@redhat.com