mgr/dashboard: Hide maintenance option on expand cluster #46702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest this please |
epuertat
approved these changes
Jun 16, 2022
Comment on lines
83
to
84
| <div class="form-group row" | ||
| *ngIf="pageURL === 'hosts'"> |
There was a problem hiding this comment.
That's ok, but (personally) I think it's preferable that conditions express what's the underlying reason for doing something.
There are multiple ways:
- For example, in the cluster expansion workflow, this component will be child/grandchild of the cluster expansion component, so if you inject that component in the constructor you'll be able to check that condition which really express why this is hidden (
if parentIsClusterCreation then hide this). - Even better, you can extend the interface of the hosts page with a new argument:
hideMaintenanceordeploymentStage, etc...
IMHO all those checks (if parentIsClusterCreation, if hideMaintenance, if deploymentStage) better reflect the intention of this change.
|
jenkins test make check |
pereman2
approved these changes
Jun 21, 2022
Comment on lines
83
to
84
| <div class="form-group row" | ||
| *ngIf="pageURL === 'hosts'"> |
|
jekins test dashboard cephadm |
|
jenkins test make check |
Fixes: https://tracker.ceph.com/issues/56070 Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
expand-cluster-hide-maintenance
branch
from
a662edd
to
d66bfe0
Compare
|
jenkins test api |
2 similar comments
|
jenkins test api |
|
jenkins test api |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/56070
Signed-off-by: Nizamudeen A nia@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows