ceph-volume: decrease number of pvs calls in lvm list
#46753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
changed the title
pvs call in lvm listpvs calls in lvm list
current implementation of `List.create_report()` implies a lot of calls to `pvs` process. This could be avoided. current implementation: ``` >>> import timeit >>> from ceph_volume.devices.lvm.listing import List >>> timeit.timeit(List([]).main, number=1000) ... 93.03700458299136 ``` new implementation: ``` >>> import timeit >>> from ceph_volume.devices.lvm.listing import List >>> timeit.timeit(List([]).main, number=1000) ... 62.16391600697534 ``` In this example, it improves performance by ~30% Fixes: https://tracker.ceph.com/issues/56127 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
jenkins test ceph-volume tox |
|
4 Failed tests from and 1 dead test from I believe these are all infra issues and I did see these same failures in another run with different PRs (and notably, not on the same tests) in Quite confident the failures are unrelated to PRs in the run, so I think we're good here. |
adk3798
approved these changes
Jul 1, 2022
This was referenced Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current implementation of
List.create_report()implies a lot of callsto
pvsprocess. This could be avoided.current implementation:
new implementation:
In this example, it improves performance by ~30%
Fixes: https://tracker.ceph.com/issues/56127
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com