Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fixes spelling #46824

Closed
wants to merge 568 commits into from
Closed

*: Fixes spelling #46824

wants to merge 568 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 23, 2022

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@32fcb4a#commitcomment-76795301

The action reports that the changes in this PR would make it happy: jsoref@9532fe5

I will be annotating this PR, and I fully expect to be asked to drop certain files.

I'm quite happy to split this PR, I'd just need a direction... It seems most likely that'd be by top level directory, but, some input would be appreciated before I go off and do that.

I understand that this PR isn't in proper form.

Contribution Guidelines

--- I'll do this at the end once I have a sense of which commits are desired and how people actually want them shaped. It's a lot easier for me to drop commits first before I spend time getting commits to match a commit style.

--- I hope that my changes won't be targeted for stable branches, but I will note that this template links to master which is something I just tripped on (I had to rebase and add some extra commits to switch from master to main).

Checklist

  • Tracker (select at least one)
    • References tracker ticket - doing this requires an account to be manually approved, I can create a ticket once I have an approved account...
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
    • Includes unit test(s)
    • Includes integration test(s)
    • Includes bug reproducer
    • No tests
      • Tests could be provided, but I generally offer them after the fact, as opposed to w/ my initial batch...
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

jsoref and others added 15 commits April 26, 2023 09:40
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@jsoref
Copy link
Contributor Author

jsoref commented Apr 26, 2023

I've torn off a bunch of things (core I'll comment on later).

I'll deal w/ cephfs later once people give me a hint about the proper codeowner rules...

@epuertat
Copy link
Member

@epuertat: oh my, your use of experimental_path isn't something I'd considered. I'd just use only for those items. e.g. only.txt for @ceph/core:

^src/mon/
^src/osd/
^src/mgr/
^src/pybind/rados

For mono-repos (like Ceph's) using something like base_path (experimental_path is tad intimidating) would be definitely useful, since sub-paths usually contain isolated components. Having to deal with regex'es will surely scare some users (vs. a plain path setting).

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@jsoref jsoref mentioned this pull request May 25, 2023
14 tasks
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 21, 2023
@jsoref
Copy link
Contributor Author

jsoref commented Jul 21, 2023

Sigh. I'll look into rebasing next week

@github-actions github-actions bot removed the stale label Jul 21, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 19, 2023
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Inactive
8 participants