Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-fuse: librados will filter out -r option from command-line #46839

Merged
merged 1 commit into from Jul 4, 2022

Conversation

maydaycc
Copy link

@maydaycc maydaycc commented Jun 24, 2022

The -r option will be filtered out by librados
when exec cmd "rbd-fuse /mountpoint -p pool_name -r rbd_name"
other rbds can be seen under the mount point

Fixes: https://tracker.ceph.com/issues/56387
Signed-off-by: wanwencong wanwc@chinatelecom.cn

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@maydaycc maydaycc requested a review from a team as a code owner June 24, 2022 16:00
@maydaycc
Copy link
Author

@tchaikov Would you please have a look at this PR?

src/rbd_fuse/rbd-fuse.cc Outdated Show resolved Hide resolved
src/rbd_fuse/rbd-fuse.cc Outdated Show resolved Hide resolved
src/rbd_fuse/rbd-fuse.cc Outdated Show resolved Hide resolved
@idryomov
Copy link
Contributor

@maydaycc Are you actually using rbd-fuse? If so, may I ask why?

rbd-nbd has been the preferred solution for many years now, is there something missing there that made you resort to rbd-fuse?

@idryomov
Copy link
Contributor

idryomov commented Jun 30, 2022

Looks like this was missed in #20598, I wonder why -- -r/--client_mountpoint option is very old (~2011).

@maydaycc
Copy link
Author

maydaycc commented Jul 1, 2022

@maydaycc Are you actually using rbd-fuse? If so, may I ask why?

rbd-nbd has been the preferred solution for many years now, is there something missing there that made you resort to rbd-fuse?

In the process of creating volumes from images, we use rbd-fuse to mount rbd to the cinder volume node, and then use the resize2fs tool to adjust the size of the file system. rbd-nbd is a better choice but our kernel does not support the nbd module.

src/rbd_fuse/rbd-fuse.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/rbd_fuse/rbd-fuse.cc Outdated Show resolved Hide resolved
@idryomov
Copy link
Contributor

idryomov commented Jul 1, 2022

@maydaycc Please fold the whitespace fixup into the original commit.

The -r option will be filtered out by librados
when exec cmd "rbd-fuse /mountpoint -p pool_name -r rbd_name"
other rbds can be seen under the mount point

Fixes: https://tracker.ceph.com/issues/56387
Signed-off-by: wanwencong <wanwc@chinatelecom.cn>
@maydaycc
Copy link
Author

maydaycc commented Jul 1, 2022

@maydaycc Please fold the whitespace fixup into the original commit.

Done!

@idryomov
Copy link
Contributor

idryomov commented Jul 4, 2022

The only job in the suite that happens to exercise rbd-fuse:

https://pulpito.ceph.com/dis-2022-07-04_09:14:19-rbd-wip-dis-testing-distro-default-smithi/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants