mgr/dashboard: prevent alert redirect #47011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0nea
requested review from
nSedrickm and
melissa-kun-li
and removed request for
a team
|
jenkins test make check |
|
jenkins test dashboard |
1 similar comment
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
epuertat
reviewed
Jul 12, 2022
Prevent Alertmanager alerts from being redirected to the active mgr dashboard instance. There are two reasons for it: 1. It doesn't bring any additional benefit. The Alertmanager config includes all available mgr instances - active and passive ones. In case of an alert, it will be sent to all of them. It ensures that the active mgr dashboard will receive the alert in any case. 2. The redirect URL includes the mgr IP and NOT the FQDN. This leads to issues in environments where an SSL certificate is configured and matches the FQDNs, only. Fixes: https://tracker.ceph.com/issues/56401 Signed-off-by: Tatjana Dehler <tdehler@suse.com>
s0nea
force-pushed
the
wip-prevent-alert-redirects
branch
from
0711c72
to
965005e
Compare
|
jenkins test dashboard |
1 similar comment
|
jenkins test dashboard |
epuertat
approved these changes
Jul 14, 2022
|
jenkins test dashboard |
|
jenkins test windows |
nizamial09
approved these changes
Jul 16, 2022
|
@s0nea don't we need to backport it to quincy (and pacific)? |
Yes! I'll take care of it. |
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent Alertmanager alerts from being redirected to the active mgr dashboard instance. There are two reasons for it:
Fixes: https://tracker.ceph.com/issues/56401
Signed-off-by: Tatjana Dehler tdehler@suse.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows