tools/crimson/perf_crimson_msgr：fix perf_crimson_msgr abort #47039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosinL Rixin, you might want to accompany each commit with an explanation why we need to have the corresponding fix. |
…sgr start running While constructing socket connections, there are some config items needed( `ceph::msgr::v2::FrameAssembler` need the value of `common::local_conf()->ms_crc_data`, Access `common::local_conf()->ms_crc_data` will cause SIGSEGV without the ConfigProxy init). So adding ConfigPorxy init before pref_crimson_msgr start running. Fixes: https://tracker.ceph.com/issues/56520 Signed-off-by: luo rixin <luorixin@huawei.com>
rosinL
force-pushed
the
fix-perf-cirmson-msgr
branch
from
54e24d8
to
33837a8
Compare
I have added some explanation, pls take a review. |
As msgr protocol V1 is no longer supported, correct default addr to msgr v2 version and replace the option 'v1-crc-enabled' to 'crc-enabled'. Fixes: https://tracker.ceph.com/issues/56520 Signed-off-by: luo rixin <luorixin@huawei.com>
rosinL
force-pushed
the
fix-perf-cirmson-msgr
branch
from
33837a8
to
d44c0f6
Compare
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While constructing socket connections, there are some config items needed(
ceph::msgr::v2::FrameAssemblerneed the value ofcommon::local_conf()->ms_crc_data,Access
common::local_conf()->ms_crc_datawill cause SIGSEGV without the ConfigProxy init).So adding ConfigPorxy init before pref_crimson_msgr start running.
Fixes: https://tracker.ceph.com/issues/56520
Signed-off-by: luo rixin luorixin@huawei.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows