Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: tweak misleading "image is still primary" error message #47242

Merged
merged 1 commit into from Jul 23, 2022
Merged

librbd: tweak misleading "image is still primary" error message #47242

merged 1 commit into from Jul 23, 2022

Conversation

idryomov
Copy link
Contributor

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@idryomov idryomov requested a review from a team as a code owner July 22, 2022 13:32
@idryomov
librbd: tweak misleading "image is still primary" error message
95dd89b 
m_promotion_state == PROMOTION_STATE_NON_PRIMARY doesn't say anything
about the remote image.  It could still be primary but it could also be
demoted.

Fixes: https://tracker.ceph.com/issues/56676
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
ideepika
ideepika approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@ideepika ideepika left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hit this yesterday myself! this looks good as well!

@idryomov
Copy link
Contributor Author

jenkins test api

@idryomov idryomov merged commit b4a66de into ceph:main Jul 23, 2022
@idryomov idryomov deleted the wip-56676 branch July 23, 2022 09:33
This was referenced Jul 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideepika ideepika ideepika approved these changes

Assignees
No one assigned
Labels
cleanup rbd
Projects
None yet
Milestone
No milestone
2 participants
@idryomov @ideepika