tools: add --no-verify option to rados bench #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing seq and rand read benchmarks using rados bench, a quite large portion of cpu time is consumed by doing object verification. This patch adds an option to disable this verification when it's not needed, in turn giving better cluster utilization. rados -p storage bench 600 rand scores without --no-verification: Total time run: 600.228901 Total reads made: 144982 Read size: 4194304 Bandwidth (MB/sec): 966 Average IOPS: 241 Stddev IOPS: 38 Max IOPS: 909522486 Min IOPS: 0 Average Latency: 0.0662 Max latency: 1.51 Min latency: 0.004 real 10m1.173s user 5m41.162s sys 11m42.961s Same command, but with --no-verify: Total time run: 600.161379 Total reads made: 174142 Read size: 4194304 Bandwidth (MB/sec): 1.16e+03 Average IOPS: 290 Stddev IOPS: 20 Max IOPS: 909522486 Min IOPS: 0 Average Latency: 0.0551 Max latency: 1.12 Min latency: 0.00343 real 10m1.172s user 4m13.792s sys 13m38.556s Note the decreased latencies, increased bandwidth and more reads performed. Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
|
Nice! Planning to try this out |
|
Nice catch! Out of curiosity, do you see similar aggregate performance increases if you run two copies of rados bench on the same client (ie spread load across multiple cores)? |
|
Actually, running two rados bench with half of concurrent ios each gives better results than one processing all of the concurrent ios. Certainly, rados bench would benefit from multithreading. |
liewegas
added a commit
that referenced
this pull request
May 27, 2015
tools: add --no-verify option to rados bench Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing seq and rand read benchmarks using rados bench, a quite large
portion of cpu time is consumed by doing object verification. This patch
adds an option to disable this verification when it's not needed, in turn
giving better cluster utilization. rados -p storage bench 600 rand scores
without --no-verification:
Total time run: 600.228901
Total reads made: 144982
Read size: 4194304
Bandwidth (MB/sec): 966
Average IOPS: 241
Stddev IOPS: 38
Max IOPS: 909522486
Min IOPS: 0
Average Latency: 0.0662
Max latency: 1.51
Min latency: 0.004
real 10m1.173s
user 5m41.162s
sys 11m42.961s
Same command, but with --no-verify:
Total time run: 600.161379
Total reads made: 174142
Read size: 4194304
Bandwidth (MB/sec): 1.16e+03
Average IOPS: 290
Stddev IOPS: 20
Max IOPS: 909522486
Min IOPS: 0
Average Latency: 0.0551
Max latency: 1.12
Min latency: 0.00343
real 10m1.172s
user 4m13.792s
sys 13m38.556s
Note the decreased latencies, increased bandwidth and more reads performed.
Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com