mgr/dashboard: capacity card #47396
Merged
mgr/dashboard: capacity card #47396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pegonzal
requested review from
pereman2 and
aaSharma14
and removed request for
a team
Pegonzal
commented
Aug 1, 2022
Pegonzal
force-pushed
the
feature-landing-page-revamp
branch
from
5b057be
to
176649c
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
epuertat
reviewed
Aug 4, 2022
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Outdated
Show resolved
Hide resolved
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Outdated
Show resolved
Hide resolved
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Outdated
Show resolved
Hide resolved
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Show resolved
Hide resolved
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard/dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard/dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard/dashboard.component.ts
Outdated
Show resolved
Hide resolved
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Pegonzal
force-pushed
the
capacity-card
branch
from
739675f
to
2b70b4f
Compare
|
@epuertat Could you review it again? I added your suggested changes and had some questions with some of them. Anyways, let me know |
epuertat
approved these changes
Aug 18, 2022
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Outdated
Show resolved
Hide resolved
Pegonzal
force-pushed
the
capacity-card
branch
from
2b70b4f
to
67cc207
Compare
Pegonzal
changed the title
|
jenkins test make check |
|
jenkins test api |
|
jenkins test dashboard |
pereman2
approved these changes
Aug 23, 2022
nizamial09
approved these changes
Aug 24, 2022
...d/mgr/dashboard/frontend/src/app/ceph/new-dashboard/dashboard-pie/dashboard-pie.component.ts
Outdated
Show resolved
Hide resolved
|
jenkins test make check |
|
jenkins test api |
|
not sure but maybe the feature branch needs to rebased against the main for all these test to pass. |
mgr/dashboard: fix variable names and using Math.round() now mgr/dashboard cluster endpoint changes mgr/dashboard: refactoring mgr/dashboard: string concatenation to interpolation and typedict to namedtuple mgr/dashboard: change function order Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Pegonzal
force-pushed
the
capacity-card
branch
from
67cc207
to
569e5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capacity card for the new dashboard page.
Currently working with two rings. One outter ring for the osd-nearFullRatio and osd-FullRatio and other ring for the capacity usage display.
Signed-off-by: Pedro Gonzalez Gomez pegonzal@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows