New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kickoff v18 reef #47458
kickoff v18 reef #47458
Conversation
jenkins test api |
jenkins test windows |
jenkins test make check |
@@ -184,7 +184,8 @@ DEFINE_CEPH_FEATURE(60, 1, OSD_RECOVERY_DELETES) // *do not share this bit* | |||
DEFINE_CEPH_FEATURE(61, 1, CEPHX_V2) // 4.19, *do not share this bit* | |||
|
|||
DEFINE_CEPH_FEATURE(62, 1, RESERVED) // do not use; used as a sentinel | |||
DEFINE_CEPH_FEATURE_DEPRECATED(63, 1, RESERVED_BROKEN, LUMINOUS) // client-facing | |||
DEFINE_CEPH_FEATURE_RETIRED(63, 1, RESERVED_BROKEN, LUMINOUS, QUINCY) // client-facing | |||
// available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X-3 == R-3 == Octopus
I don't think RESERVED_BROKEN
was tied to Octopus or the "X-3" rule. But deciding that it has been long enough for OSD_SNAPMAPPER
workaround to go away entirely is fine too :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can retire this bit, let's go for it.
Just to the record the meaning of the macros' params:
// this bit is ignored but still advertised by release *when*
#define DEFINE_CEPH_FEATURE_DEPRECATED(bit, incarnation, name, when) \
const static uint64_t DEPRECATED_CEPH_FEATURE_##name = (1ULL<<bit); \
const static uint64_t DEPRECATED_CEPH_FEATUREMASK_##name = \
(1ULL<<bit | CEPH_FEATURE_INCARNATION_##incarnation);
// this bit is ignored by release *unused* and not advertised by
// release *unadvertised*
#define DEFINE_CEPH_FEATURE_RETIRED(bit, inc, name, unused, unadvertised)
c7c368a
to
5d5a8e2
Compare
The make check bot failed early:
|
jenkins test make check |
cc @tchaikov motr still causing 'make check' failures:
i've opened #47564 to disable WITH_RADOSGW_MOTR in make check until we stabilize our CI |
@cbodley turns out cortx-motr upstreams debian packaging receipt is buggy, and missing that file. just added it and reupload the deb packages. diff --git a/debian/cortx-motr-dev.install b/debian/cortx-motr-dev.install
index 6c7dfb54..33414fe0 100644
--- a/debian/cortx-motr-dev.install
+++ b/debian/cortx-motr-dev.install
@@ -239,6 +239,7 @@ usr/include/motr/fop/fom_simple.h
usr/include/motr/fop/fop.h
usr/include/motr/fop/fop_item_type.h
usr/include/motr/fop/ut/iterator_test_xc.h
+usr/include/motr/fop/wire.h
usr/include/motr/format/format.h
usr/include/motr/format/format_xc.h
usr/include/motr/graph/graph.h patch upstreamed at Seagate/cortx-motr#2074 |
"make check" failure pertains to this PR:
|
Added |
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3ee53b8
to
67b7bdb
Compare
Resolved a merge conflict with acd6d4e on |
Fixing. No other things than just the |
…omplete. Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
…nt) == 10 Also updates the release checklist. Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
c667ad9
to
130704e
Compare
Absolutely no other changes except the doc's indentation:
|
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Bumped librbd version and added respective items to the checklist. |
jenkins retest this please |
@rzarzynski I only found one related failure. But I think you fixed it in a subsequent commit since it passed in the rerun. And I see the commit on your branch.
Rados suite review: Failures, unrelated: Details: |
Since ceph/ceph/pull/47458 has been merged, this check must be updated. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Since ceph/ceph/pull/47458 has been merged, this task needs to be updated. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
align with ceph/ceph/pull/47458 since it has been merged. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
align with ceph/ceph/pull/47458 since it has been merged. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
align with ceph/ceph/pull/47458 since it has been merged. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Rook daily tests against Ceph main are green since this is merged and Rook can detect the Reef version, thanks! |
yikes, i hadn't noticed that this PR inadvertently removed rgw from the upgrade suites entirely. are the upgrade suites cephadm-only now? i've opened https://tracker.ceph.com/issues/58782 to track this |
okay, i see this just removed all octopus-x upgrade suites, and we never made any "no-cephadm" upgrade suites after that |
align with ceph/ceph/pull/47458 since it has been merged. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows