mgr/prometheus: expose repaired pgs metrics

[pereman2]

Expose num_objects_repaired so users can monitor auto repaired pgs.

Signed-off-by: Pere Diaz Bou pdiazbou@redhat.com
Fixes: https://tracker.ceph.com/issues/57623

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[epuertat]

Besides my comments on the granularity, I'd like to see a new alert here or a new Dashboard. Personally, I don't think that we should add new metrics if they don't result in anything visible to the operator (via a dashboard or peferrably, an alert).

[nizamial09]

jenkins test make check

[nizamial09]

jenkins test windows

[nizamial09]

a few lint errors here but apart from that it looks good

flake8 run-test: commands[0] | flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest
prometheus/module.py:1570:21: E126 continuation line over-indented for hanging indent
prometheus/module.py:1574:21: E123 closing bracket does not match indentation of opening bracket's line
prometheus/module.py:1575:1: W293 blank line contains whitespace
prometheus/module.py:1576:78: W291 trailing whitespace
prometheus/module.py:1577:21: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
1     E126 continuation line over-indented for hanging indent
1     E128 continuation line under-indented for visual indent
1     W291 trailing whitespace
1     W293 blank line contains whitespace
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/flake8/bin/flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest (exited with code 1)

[idryomov]

@pereman2 Why is this metric specifies poolid label instead of pool_id like (all?) other metrics?

The ones that are closely related such as num_objects_recovered or objects certainly use pool_id. It would be nice to be consistent.