rgw/s3: align output format with client request #47577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbenjamin
changed the title
mattbenjamin
force-pushed
the
wip-rgw-55680
branch
from
133928e
to
9a9cb4c
Compare
cbodley
approved these changes
Aug 16, 2022
src/rgw/rgw_common.h
Outdated
| HTML, | ||
| }; | ||
|
|
||
| static inline const char* toString(const RGWFormat f) |
There was a problem hiding this comment.
to_string() functions are a good way to associate names with the values of an enum class
in this case though, the strings we want are not just enum names but MIME types. could we call this function to_mime_type() instead?
alternatively, we could rename the enum from RGWFormat to RGWMimeType so it's more obvious what to_string() will give you - but RGWFormat makes sense in that it controls which kind of ceph::Formatter we construct
There was a problem hiding this comment.
I agree, I thought about that after sending. I think it's better to rename the method.
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Also conditionally prints policy and resource in verify_bucket_permission. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
This is a pure cleanup. The method to print an RGWFormat object as a MIME type is now called to_mime_type(). Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
In general, e.g., in the S3 ListBucket response, the output Formatter is already of the type requested in the HTTP Accept header. Therefore, while there are still many instances where the of Formatter is assumed to be XML, it appears necessarily safe and seemingly correct to extend this assumption to end_header(...), which sends the response content-type. Fixes: https://tracker.ceph.com/issues/55680 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-rgw-55680
branch
from
9a9cb4c
to
7ad5386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows