Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: rbd: find_action() should sort actions first #47584

Merged
merged 2 commits into from Aug 25, 2022
Merged

quincy: rbd: find_action() should sort actions first #47584

merged 2 commits into from Aug 25, 2022

Conversation

idryomov
Copy link
Contributor

@idryomov
rbd: find_action() should sort actions first
a9776fd 
The order in which objects with static storage duration in
different TUs are initialized is undefined.  If the compiler
chooses to initialize Shell::Action objects in action/Trash.cc
before Shell::Action objects in action/TrashPurgeSchedule.cc,
all "rbd trash purge schedule ..." commands get shadowed by
"rbd trash purge" command:

$ rbd trash purge schedule list
rbd: too many arguments

The confusing error arises because "rbd trash purge" takes a single
positional argument.  "schedule" gets interpreted as <pool-spec> and
"list" generates an error.

Fixes: https://tracker.ceph.com/issues/57107
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e0b428a)
@idryomov
rbd: remove incorrect use of std::includes()
94ad8cd 
- std::includes() requires sorted ranges but command specs aren't
  sorted
- std::includes() purpose is to check whether the second range is
  a subsequence of the first range but here the size of the second
  range is always equal to the size of the first range, which means
  that, had the ranges been sorted, std::includes() would have checked
  straight equality

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1483e2a)
@idryomov idryomov added this to the quincy milestone Aug 14, 2022
@idryomov idryomov requested a review from a team as a code owner August 14, 2022 16:34
@idryomov
Copy link
Contributor Author

idryomov commented Aug 14, 2022 •
edited

make check is blocked on #47585 and #47625

@idryomov
Copy link
Contributor Author

jenkins test make check

1 similar comment
@idryomov
Copy link
Contributor Author

jenkins test make check

@tchaikov
Copy link
Contributor

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented Aug 18, 2022

jenkins test api

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Aug 19, 2022

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented Aug 19, 2022

@idryomov api tests failing fyi

@idryomov
Copy link
Contributor Author

Not an RBD issue, see #47325 (comment).

@yuriw
Copy link
Contributor

yuriw commented Aug 22, 2022

jenkins test api

@yuriw yuriw merged commit 7d58977 into ceph:quincy Aug 25, 2022
@idryomov idryomov deleted the wip-57107-quincy branch August 25, 2022 15:35
@ljflores
Copy link
Contributor

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri7-testing-2022-08-17-0943-quincy

Failures, unrelated:
1. https://tracker.ceph.com/issues/57303 -- new Tracker; unrelated to PRs in this run
2. https://tracker.ceph.com/issues/52321
3. https://tracker.ceph.com/issues/57303
4. https://tracker.ceph.com/issues/56951
5. https://tracker.ceph.com/issues/57270 -- Pending Quincy backport
6. https://tracker.ceph.com/issues/57165 -- Fix under review; pending Quincy backport
7. https://tracker.ceph.com/issues/49287

Details:
1. rados/cephadm: Failed to fetch package version from https://shaman.ceph.com/api/search/?status=ready&project=ceph&flavor=default&distros=ubuntu%2F22.04%2Fx86_64&sha1=b34ca7d1c2becd6090874ccda56ef4cd8dc64bf7 - Ceph - Orchestrator
2. qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Ceph - Rook
3. AssertionError: Expected to find element: cd-modal .badge:not(script,style):cy-contains('/^foo$/'), cd-modal .badge[type='submit'][value~='/^foo$/'], but never found it. - Ceph - Mgr - Dashboard
4. rook/smoke: Updating cephclusters/rook-ceph is forbidden - Ceph - Orchestrator
5. cephadm: RuntimeError: Failed command: apt-get update: E: The repository 'https://download.ceph.com/debian-octopus jammy Release' does not have a Release file. - Ceph - Orchestrator
6. expected valgrind issues and found none - Ceph - RADOS
7. podman: setting cgroup config for procHooks process caused: Unit libpod-$hash.scope not found - Ceph - Orchestrator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

Assignees
No one assigned
Labels
bug-fix needs-qa quincy-batch-1 rbd wip-yuri7-testing
Projects
None yet
Milestone
quincy
5 participants
@idryomov @tchaikov @yuriw @ljflores @trociny