Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutex: fix memory leak in lockdep _register #4760

Merged
merged 1 commit into from Jun 2, 2015

Conversation

ketor
Copy link
Contributor

@ketor ketor commented May 26, 2015

Need pthread_mutexattr_destroy after pthread_mutexattr_init,
or there will be memory leak.

Signed-off-by: Ketor Meng d.ketor@gmail.com

@tchaikov
Copy link
Contributor

@ketor good catch! could you add a title for your commit message? something like:

Mutex: fix leak of pthread_mutexattr

will do the trick.

and do you mind creating an issue in http://tracker.ceph.com, since this issue is a critical fix. would be great if we are able to track it in the redmine. thanks =)

@ketor
Copy link
Contributor Author

ketor commented May 26, 2015

@tchaikov
Copy link
Contributor

@ketor, and could you also connect the ticket with your commit using the commit message? you could put following line right before the "Signed-off-by" line.

Fixes: #111762

and other than this, the fix looks great.

Need pthread_mutexattr_destroy after pthread_mutexattr_init

Fixes: #111762
Signed-off-by: Ketor Meng <d.ketor@gmail.com>
@ketor
Copy link
Contributor Author

ketor commented May 26, 2015

@tchaikov please review again, thanks!

@tchaikov tchaikov changed the title Fix Memory Leak in lockdep _register Mutex: fix memory leak in lockdep _register May 26, 2015
@tchaikov
Copy link
Contributor

tchaikov commented Jun 2, 2015

tested at http://pulpito.ceph.redhat.com/kchai-2015-06-01_00:05:54-rados-wip-kefu-testing---basic-magna, all of the tests but 1 passed.
and the failed test passed at http://pulpito.ceph.redhat.com/kchai-2015-06-02_05:49:24-rados-wip-kefu-testing---basic-magna

$ teuthology-suite --verbose --priority 101 --suite rados --subset 0/20 --suite-branch master --machine-type magna  --distro ubuntu --email tchaikov@gmail.com --ceph wip-kefu-testing
$ teuthology-suite --filter="rados/thrash/{0-size-min-size-overrides/3-size-2-min-size.yaml 1-pg-log-overrides/short_pg_log.yaml clusters/fixed-2.yaml fs/xfs.yaml msgr-failures/fastclose.yaml thrashers/mapgap.yaml workloads/rgw_snaps.yaml}" --priority 101 --suite rados --subset 0/18 --suite-branch master --machine-type magna --distro ubuntu --email tchaikov@gmail.com --ceph wip-kefu-testing

tchaikov added a commit that referenced this pull request Jun 2, 2015
Mutex: fix memory leak in lockdep _register

Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit aa3d269 into ceph:master Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants