Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-mixin: fix config inheritance #47675

Merged
merged 1 commit into from Aug 29, 2022
Merged

Conversation

bosc0
Copy link

@bosc0 bosc0 commented Aug 18, 2022

The changes to alerts introduced in 5cdc1c6 don't allow the config to be overwritten, this PR fixes the issue.

Signed-off-by: Aswin Toni aswin.toni@cern.ch

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
@bosc0 bosc0 requested a review from a team as a code owner August 18, 2022 15:09
@bosc0 bosc0 requested review from nSedrickm and Pegonzal and removed request for a team August 18, 2022 15:09
@MrFreezeex
Copy link
Member

jenkins test api

@MrFreezeex
Copy link
Member

jenkins test make check

@MrFreezeex
Copy link
Member

jenkins test api

1 similar comment
@MrFreezeex
Copy link
Member

jenkins test api

@MrFreezeex
Copy link
Member

jenkins test make check

@MrFreezeex MrFreezeex merged commit ff06790 into ceph:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants