pacific: Update fio in pacific branch to fix `make check` failures #47696

tserong · 2022-08-19T07:49:38Z

I'm trying to cherry pick d777100 in order to fix the make check failure mentioned in #47401 (comment). The cleanest way I could find to do this, avoiding needing to resolve any conflicts, seems to be to grab these four commits.

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

for better readability and maintainability Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit c190fee)

to pick up the clang build fix. we should use the upstream repo, once the clang build fix gets merged. bumping up the fio helps to address following error, as this part was rewritten: src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/fio_ceph_objectstore.cc.o.d -o src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/fio_ceph_objectstore.cc.o -c ../src/test/fio/fio_ceph_objectstore.cc In file included from ../src/test/fio/fio_ceph_objectstore.cc:26: In file included from src/fio/fio.h:18: In file included from src/fio/thread_options.h:6: In file included from src/fio/options.h:8: src/fio/parse.h:128:13: error: arithmetic on a pointer to void return ret + offset; ~~~ ^ 1 error generated. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 10baab3)

this change partially reverts 10baab3, but since the fix for C++ build is not included by any tag or branche so far. let's just use the sha1 for now. Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit b65d074)

to address following warning: fatal: reference is not a tree: 7f02f21f53ccd5e2448086f8e9015489693dd2dc CMake Error at /home/jenkins-build/build/workspace/ceph-pull-requests/build/fio_ext-prefix/tmp/fio_ext-gitclone.cmake:40 (message): Failed to checkout tag: '7f02f21f53ccd5e2448086f8e9015489693dd2dc' it seems that the shallow option does not work with a sha1 tag option, let's continue using the ceph repo with a tag. Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit d777100)

tserong · 2022-08-19T08:02:57Z

Now what?!?

CMake Error at cmake/modules/Distutils.cmake:81 (message):
  Unable to tell python extension's suffix: Traceback (most recent call
  last):

    File "<string>", line 1, in <module>

  ImportError: cannot import name 'sysconfig' from 'distutils'
  (/usr/lib/python3.8/distutils/__init__.py)

Call Stack (most recent call first):
  src/pybind/rados/CMakeLists.txt:1 (distutils_add_cython_module)

tchaikov · 2022-08-19T08:23:07Z

@tserong sorry for the headaches. might want to backport f0fc04f and 637dd7b as well.

less redirections Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit f0fc04f)

to address following warning from python 3.9: <string>:1: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives <string>:1: DeprecationWarning: The distutils.sysconfig module is deprecated, use sysconfig instead Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 637dd7b)

tserong · 2022-08-19T08:35:58Z

Thanks @tchaikov! :-)

tserong · 2022-08-19T10:00:58Z

OK, now I'm getting:

/usr/include/fmt/core.h:1728:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt

...which looks suspiciously like bb9d099, but that won't cherry-pick by itself (more conflicts). I'll have to pick this up again on Monday (sorry!)

tchaikov · 2022-08-19T10:10:12Z

or, we can disable the WITH_SEASTAR option on LTS branches. as crimson is still under active development. it does not help to build or test it on the LTS branches.

tserong · 2022-08-22T03:45:16Z

or, we can disable the WITH_SEASTAR option on LTS branches. as crimson is still under active development. it does not help to build or test it on the LTS branches.

Good idea. How do I do that? I assume that's in the CI infra somewhere and not something I can tweak in the ceph source?

tserong · 2022-08-22T04:09:14Z

...oh, wait, I have an idea...

tserong · 2022-08-22T04:27:55Z

The fun continues...

CMake Error at src/pybind/CMakeLists.txt:74 (message):
  Python and Ceph link to different OpenSSL versions: 1.1.1

   vs 3.0.2

There's no way that's related to anything I've got here, surely?

Update: that failure (https://jenkins.ceph.com/job/ceph-pull-requests/102006/consoleFull#-20391438177641bc0b-bacc-4481-8290-0cf28df0ce68) was a build running with python3.8, whereas the build I've just kicked off now with my request to jenkins below, seems to be using python3.10, and did not fail with the above error... I wonder if python version is significant here?

tserong · 2022-08-22T04:37:10Z

jenkins test make check

tserong · 2022-08-22T04:50:54Z

jenkins test api

tserong · 2022-08-22T05:48:52Z

Those last two commits will hopefully fix ImportError: cannot import name 'Sequence' from 'collections' (/usr/lib/python3.10/collections/__init__.py) running dashboard tests (https://jenkins.ceph.com/job/ceph-pull-requests/102008/)

tserong · 2022-08-22T08:13:01Z

OK, make check is good. As for the API tests, the mgr log from https://jenkins.ceph.com/job/ceph-api/43074/ has:

2022-08-22T05:52:31.271+0000 7fe6fca7b500 -1 mgr[py] Module not found: 'dashboard'
2022-08-22T05:52:31.271+0000 7fe6fca7b500 -1 mgr[py] Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/__init__.py", line 61, in <module>
    from .module import Module, StandbyModule  # noqa: F401
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/module.py", line 51, in <module>
    patch_cherrypy(cherrypy.__version__)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/cherrypy_backports.py", line 197, in patch_cherrypy
    accept_socket_error_0(v)
  File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/cherrypy_backports.py", line 124, in accept_socket_error_0
    if v < StrictVersion("9.0.0") or cheroot_version < StrictVersion("6.5.5"):
  File "/usr/lib/python3.10/distutils/version.py", line 64, in __gt__
    c = self._cmp(other)
  File "/usr/lib/python3.10/distutils/version.py", line 168, in _cmp
    other = StrictVersion(other)
  File "/usr/lib/python3.10/distutils/version.py", line 40, in __init__
    self.parse(vstring)
  File "/usr/lib/python3.10/distutils/version.py", line 137, in parse
    raise ValueError("invalid version number '%s'" % vstring)
ValueError: invalid version number '8.5.2+ds1'

2022-08-22T05:52:31.271+0000 7fe6fca7b500 -1 mgr[py] Class not found in module 'dashboard'
2022-08-22T05:52:31.271+0000 7fe6fca7b500 -1 mgr[py] Error loading module 'dashboard': (2) No such file or directory

This looks like https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1967139, which (if I'm reading it correctly) should have been fixed about a week ago.

tserong · 2022-08-22T09:01:29Z

Can anyone assist in getting an updated python3-cheroot installed on braggi*, per the ubuntu bug in my previous comment?

tserong · 2022-08-25T04:37:14Z

Right, done.

tserong · 2022-08-25T04:56:04Z

jenkins test make check

tchaikov · 2022-08-25T05:02:06Z

there're lots of old friends in the failed tests.

the unittest_rgw_dmclock_scheduler failure is tracked by https://tracker.ceph.com/issues/40069

tserong · 2022-08-25T05:20:07Z

That is old. Happily(?) another run got us through make check...

tserong · 2022-08-25T05:34:06Z

jenkins test dashboard

tserong · 2022-08-25T05:54:04Z

I've pushed this to https://github.com/ceph/ceph-ci/tree/wip-tserong-testing to try to get package builds, but I can't see that branch at https://shaman.ceph.com/builds/ceph/ - did I miss a step somewhere?

tserong · 2022-08-25T06:50:16Z

Aha! wip-tserong-testing was identical to wip-pacific-update-fio-kefu-2, including all commit hashes, so I assume something was smart enough to not bother building my branch. So I've just done a reword of the last commit in wip-tserong-testing, without making any actual changes, to force a new hash, and now it seems to be building.

tserong · 2022-08-25T06:56:10Z

(Note that the build I just triggered of wip-tserong-testing is presumably not actually necessary as https://shaman.ceph.com/builds/ceph/wip-pacific-update-fio-kefu-3/ is the same source, and looks pretty good to me)

tchaikov · 2022-08-25T08:23:45Z

https://shaman.ceph.com/builds/ceph/wip-tserong-testing/2864d6a280d94e3a4249df5ca1bd1905609fe3a9/default/315496/

ln -sf libpmemobj.so.1 ../debug/libpmemobj/../libpmemobj.so
make[7]: Leaving directory '/build/ceph-16.2.10-678-g2864d6a2/src/pmdk/src/libpmemobj'
/usr/bin/ld: pmemblk_priv_funcs.o (symbol from plugin): in function `_Malloc':
(.text+0x0): multiple definition of `_Malloc'; ../nondebug/libpmempool/alloc.o (symbol from plugin):(.text+0x0): first defined here
/usr/bin/ld: pmemblk_priv_funcs.o (symbol from plugin): in function `_Malloc':

needs backport of #47449 (its quincy backport is at #47619). i really wish i could say "this must be the last one". but i don't dare ..

tserong · 2022-08-25T08:57:09Z

Thanks for hunting that down @tchaikov. I'll try the quincy backport rather than pushing pacific up to gcc 11.

See-also: https://tracker.ceph.com/issues/54473 Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 2a97033) Conflicts: cmake/modules/Buildpmem.cmake: trivial resolution

tserong · 2022-08-25T09:02:09Z

...and away we go again. This PR really is a gift that keeps on giving ;-P

tserong · 2022-08-25T09:33:29Z

https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=jammy,DIST=jammy,MACHINE_SIZE=gigantic/65064//consoleFull:

/tmp/cc1zIejP.s: Assembler messages:
/tmp/cc1zIejP.s: Error: invalid attempt to declare external version name as default in symbol `rados_create@@'
make[5]: *** [/tmp/ccHQWBW3.mk:2: /tmp/cccSMOhU.ltrans0.ltrans.o] Error 1
make[5]: *** Waiting for unfinished jobs....
lto-wrapper: fatal error: make returned 2 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make[4]: *** [src/librados/CMakeFiles/librados.dir/build.make:144: lib/librados.so.2.0.0] Error 1

tserong · 2022-08-25T10:30:30Z

The previous comment was ubuntu jammy failing.

Ubuntu focal and centos 9 are fine.

Centos 8 (https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/65064//consoleFull) fails with:

[...]
No match for argument: ceph-volume
No match for argument: ceph-exporter
Error: Unable to find a match: ceph-volume ceph-exporter
Error: error building at STEP "RUN yum install -y epel-release && yum install -y jq && bash -c ' [ ..... ]  ceph-volume         ceph-exporter && echo 'Packages verified successfully'": error while running runtime: exit status 1

tchaikov · 2022-08-25T10:44:45Z

that's caused by LTO. #42602 is the cure.

The build fails because the function definitions are out of order. This also reuses the LIBRADOS_C_API_DEFAULT_F macro for function definitions. Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit d79efb0)

The gcc compiler now supports symver attribute. We should update the symvers to be able to support LTO. Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit e761933)

We can now use LTO when building ceph. The symver issue was fixed by using the gcc __symver__ attribute. The systems that support it can now re-enable LTO. Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit 381507a)

the __asm__(".asmver ..") is a support provided by the compiler, so would be better to detect it by either checking the compiler identifer or just try it out. in this change, instead of checking the building platform, we check this feature using check_c_source_compiles(). in future, we could support versioned symbols using function attriubte or symbol tables or version-script. on platform where symbol versioning is not supported, we might need to go with a different approach. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit d0858db)

Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit f90e26c)

We should check if -flto-partition=none is defined when the compiler does not support symver attribute and fail the build if it is not. Fixes: https://tracker.ceph.com/issues/40060 Co-authored-by: Kefu Chai <tchaikov@gmail.com> Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit 5bcfd5c)

We should check if either asm symver or attribute symver is defined and not assume that attribute symver implies asm symver. Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit ff1941a)

tserong · 2022-08-25T11:13:45Z

Jammy build (https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=jammy,DIST=jammy,MACHINE_SIZE=gigantic/65070//consoleFull) is now giving:

/usr/share/cmake-3.22/Modules/CheckFunctionExists.c:17: undefined reference to `pthread_set_name_np'
...
/usr/share/cmake-3.22/Modules/CheckFunctionExists.c:17: undefined reference to `pthread_get_name_np'
...
/usr/share/cmake-3.22/Modules/CheckFunctionExists.c:17: undefined reference to `getprogname'
...

(I'm going to have to leave this for today and pick it up again tomorrow)

tchaikov · 2022-08-25T11:45:25Z

lemme hold the torch for a while. see #47803

ljflores · 2022-08-25T17:15:58Z

Let's close this one in favor of #47803. @tserong @tchaikov thanks for all your hard work on finding the right commits.

tserong · 2022-08-25T22:39:10Z

Closing per previous comment. Thanks everyone!

tchaikov and others added 4 commits August 19, 2022 17:39

cmake: pass compile options by fio interface library

be0bbc9

for better readability and maintainability Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit c190fee)

cmake: use upstream repo for fio

ddf6e61

this change partially reverts 10baab3, but since the fix for C++ build is not included by any tag or branche so far. let's just use the sha1 for now. Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit b65d074)

tserong added the build/ops label Aug 19, 2022

tserong requested a review from tchaikov August 19, 2022 07:49

github-actions bot added the tests label Aug 19, 2022

github-actions bot added this to the pacific milestone Aug 19, 2022

tchaikov added 2 commits August 19, 2022 18:35

cmake/modules: drop a cmake variable

0f4b87c

less redirections Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit f0fc04f)

github-actions bot added the pybind label Aug 19, 2022

tserong requested a review from a team as a code owner August 22, 2022 05:45

tserong requested review from nizamial09 and Pegonzal and removed request for a team August 22, 2022 05:45

github-actions bot added the dashboard label Aug 22, 2022

github-actions bot added this to In progress in Dashboard Aug 22, 2022

github-actions bot added the documentation label Aug 25, 2022

tchaikov mentioned this pull request Aug 25, 2022

[DNM] pacific: Update fio in pacific branch to fix make check failures #47793

Closed

14 tasks

cmake: disable LTO when building pmdk

919e55f

See-also: https://tracker.ceph.com/issues/54473 Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 2a97033) Conflicts: cmake/modules/Buildpmem.cmake: trivial resolution

b-ranto and others added 7 commits August 25, 2022 20:51

rados: Update symver defs

2993881

The gcc compiler now supports symver attribute. We should update the symvers to be able to support LTO. Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit e761933)

librados/librados_c: Use symver attribute if available

7027b52

Fixes: https://tracker.ceph.com/issues/40060 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit f90e26c)

tserong closed this Aug 25, 2022

Dashboard automation moved this from Reviewer approved to Done Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pacific: Update fio in pacific branch to fix `make check` failures #47696

pacific: Update fio in pacific branch to fix `make check` failures #47696

tserong commented Aug 19, 2022

tserong commented Aug 19, 2022

tchaikov commented Aug 19, 2022

tserong commented Aug 19, 2022

tserong commented Aug 19, 2022

tchaikov commented Aug 19, 2022

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022 •

edited

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022 •

edited

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tchaikov commented Aug 25, 2022 •

edited

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022 •

edited

tchaikov commented Aug 25, 2022 •

edited

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tchaikov commented Aug 25, 2022

tserong commented Aug 25, 2022

tchaikov commented Aug 25, 2022 •

edited

ljflores commented Aug 25, 2022

tserong commented Aug 25, 2022

pacific: Update fio in pacific branch to fix make check failures #47696

pacific: Update fio in pacific branch to fix make check failures #47696

Conversation

tserong commented Aug 19, 2022

Contribution Guidelines

Checklist

tserong commented Aug 19, 2022

tchaikov commented Aug 19, 2022

tserong commented Aug 19, 2022

tserong commented Aug 19, 2022

tchaikov commented Aug 19, 2022

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022 • edited

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022 • edited

tserong commented Aug 22, 2022

tserong commented Aug 22, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tchaikov commented Aug 25, 2022 • edited

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022 • edited

tchaikov commented Aug 25, 2022 • edited

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tserong commented Aug 25, 2022

tchaikov commented Aug 25, 2022

tserong commented Aug 25, 2022

tchaikov commented Aug 25, 2022 • edited

ljflores commented Aug 25, 2022

tserong commented Aug 25, 2022

pacific: Update fio in pacific branch to fix `make check` failures #47696

pacific: Update fio in pacific branch to fix `make check` failures #47696

tserong commented Aug 22, 2022 •

edited

tserong commented Aug 22, 2022 •

edited

tchaikov commented Aug 25, 2022 •

edited

tserong commented Aug 25, 2022 •

edited

tchaikov commented Aug 25, 2022 •

edited

tchaikov commented Aug 25, 2022 •

edited