qa/tasks/mgr/dashboard: accept headers as a param #47720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
requested review from
nizamial09 and
Pegonzal
and removed request for
a team
tchaikov
force-pushed
the
wip-mgr-dashboard-test-with-headers
branch
from
a87030f
to
f5488e9
Compare
tchaikov
force-pushed
the
wip-mgr-dashboard-test-with-headers
branch
from
f5488e9
to
b2ce80f
Compare
tchaikov
changed the title
* add optional "headers" parameter to _request() and _get()
* correct the test of test_force_no_gzip, as the header in response
should be "application/vnd.ceph.api.v1.0+json", not "application/json"
with this change, we are able to pass headers to _get() in dashboard api
tests.
without this change, we'd have following error when testing
`test_force_no_gzip` defined by `tasks.mgr.dashboard.test_requests.RequestsTest`:
raceback (most recent call last):
File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/services/exception.py", line 47, in dashboard_exception_handler
return handler(*args, **kwargs)
File "/usr/lib/python3/dist-packages/cherrypy/_cpdispatch.py", line 54, in __call__
return self.callable(*self.args, **self.kwargs)
File "/home/jenkins-build/build/workspace/ceph-api/src/pybind/mgr/dashboard/controllers/_base_controller.py", line 263, in inner
ret = func(*args, **kwargs)
TypeError: Summary.__call__() got an unexpected keyword argument 'headers'
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
wip-mgr-dashboard-test-with-headers
branch
from
b2ce80f
to
afe8058
Compare
nizamial09
approved these changes
Aug 22, 2022
|
this change introduces https://tracker.ceph.com/issues/57256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we are able to pass headers to _get() in dashboard api tests.
without this change, we'd have following error when testing
test_force_no_gzipdefined bytasks.mgr.dashboard.test_requests.RequestsTest:Signed-off-by: Kefu Chai tchaikov@gmail.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows