Wip client fsync #4778
Wip client fsync #4778
Conversation
|
Looks sane, I will try writing an automated test today |
| @@ -3711,8 +3731,9 @@ int Client::mark_caps_flushing(Inode *in) | |||
| int flushing = in->dirty_caps; | |||
| assert(flushing); | |||
|
|
|||
| if (flushing && !in->flushing_caps) { | |||
| if (!in->flushing_caps) { | |||
There was a problem hiding this comment.
You're just clearing out the flushing check here because we already asserted it above, or was there some other reason?
There was a problem hiding this comment.
On Fri, May 29, 2015 at 6:21 AM, Gregory Farnum notifications@github.com
wrote:
In src/client/Client.cc
#4778 (comment):@@ -3711,8 +3731,9 @@ int Client::mark_caps_flushing(Inode *in)
int flushing = in->dirty_caps;
assert(flushing);
- if (flushing && !in->flushing_caps) {
- if (!in->flushing_caps) {
You're just clearing out the flushing check here because we already
asserted it above, or was there some other reason?the assertion above is the reason I remove it
Reply to this email directly or view it on GitHub
https://github.com/ceph/ceph/pull/4778/files#r31283951.
Current code always updates flushing_cap_seq when marking dirty caps as flushing. If there are old flushing caps, updating flushing_cap_seq confuses Client::wait_sync_caps(uint64_t), make it think that the old caps have been flushed. Signed-off-by: Yan, Zheng <zyan@redhat.com>
Client::_fsync() calls Client::wait_sync_caps(uint64_t), which waits for all inodes' flush caps. It's suboptimal, this patch makes Client::_fsync() wait for flushing caps which belong to the fsync inode. Signed-off-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Client::flush_caps(Inode *, MetaSession *) does not start flushing dirty caps. It only re-send caps message for caps that are already being flushed. Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
updated. only removed the out-dated comment for wait_sync_caps() |
|
@jcsp's test: ceph/ceph-qa-suite#449 |
No description provided.