Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: rgw_d3n_datacache.cc add check for musl #47831

Merged
merged 1 commit into from Sep 2, 2022

Conversation

a16bitsysop
Copy link
Contributor

@a16bitsysop a16bitsysop commented Aug 27, 2022

aio_init is glibc specific

Fixes: https://tracker.ceph.com/issues/54414
Signed-off-by: Duncan Bellamy dunk@denkimushi.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

aio_init is glibc specific

Fixes: https://tracker.ceph.com/issues/54414
Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>
@github-actions github-actions bot added the rgw label Aug 27, 2022
@@ -97,7 +100,7 @@ void D3nDataCache::init(CephContext *_cct) {
if (conf_eviction_policy == "random")
eviction_policy = _eviction_policy::RANDOM;

#if defined(HAVE_LIBAIO)
#if defined(HAVE_LIBAIO) && defined(__GLIBC__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks valid

@cbodley
Copy link
Contributor

cbodley commented Sep 1, 2022

jenkins test make check

1 similar comment
@cbodley
Copy link
Contributor

cbodley commented Sep 1, 2022

jenkins test make check

@cbodley
Copy link
Contributor

cbodley commented Sep 2, 2022

@cbodley
Copy link
Contributor

cbodley commented Sep 2, 2022

jenkins test make check

@cbodley cbodley merged commit 03d8457 into ceph:main Sep 2, 2022
@a16bitsysop a16bitsysop deleted the libaio-musl branch September 2, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants