Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: use actual monitor addresses when creating a peer bootstrap token #47835

Merged
merged 1 commit into from
Aug 31, 2022
Merged

librbd: use actual monitor addresses when creating a peer bootstrap token #47835

merged 1 commit into from
Aug 31, 2022

Conversation

idryomov
Copy link
Contributor

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@idryomov
librbd: use actual monitor addresses when creating a peer bootstrap t…
de0ba80 
…oken

Relying on mon_host config option is fragile, as the user may confuse
v1 and v2 addresses, group them incorrectly, etc.  Get mon_host value
only as a fallback.

Fixes: https://tracker.ceph.com/issues/57317
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@idryomov idryomov requested a review from a team as a code owner August 27, 2022 16:01
@github-actions github-actions bot added the tests label Aug 27, 2022
chrisphoffman
chrisphoffman reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@chrisphoffman chrisphoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this patch correctly, if there's no mon addresses already known, use ceph.conf config value. What are the cases where it will fallback?

If one wants to specify specific addresses via ceph.conf is it useful to allow for override to this? Do you anticipate any problems with clusters already relying on mon_host option set explicitly? For example, firewalls, specific eth interfaces for mon etc.

@idryomov
Copy link
Contributor Author

idryomov commented Aug 29, 2022 •
edited

If I understand this patch correctly, if there's no mon addresses already known, use ceph.conf config value. What are the cases where it will fallback?

Unknown to me... I actually had an assert for mon_addrs != nullptr && !mon_addrs->empty() there but then decided to keep the conf branch as a fallback just in case.

If one wants to specify specific addresses via ceph.conf is it useful to allow for override to this? Do you anticipate any problems with clusters already relying on mon_host option set explicitly? For example, firewalls, specific eth interfaces for mon etc.

They would need to add mirror peers manually with ... peer add on each cluster. ... peer bootstrap create/... peer bootstrap import is intended to be a hands-off solution.

trociny
trociny approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idryomov
Copy link
Contributor Author

No related failures:

https://pulpito.ceph.com/dis-2022-08-30_20:04:31-rbd-wip-dis-testing-distro-default-smithi/
https://pulpito.ceph.com/dis-2022-08-31_07:02:31-rbd-wip-dis-testing-distro-default-smithi/
https://pulpito.ceph.com/dis-2022-08-31_14:51:52-rbd-wip-dis-testing-distro-default-smithi/

@idryomov idryomov merged commit 6a8134e into ceph:main Aug 31, 2022
@idryomov idryomov deleted the wip-57317 branch August 31, 2022 16:56
This was referenced Sep 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

@chrisphoffman chrisphoffman chrisphoffman approved these changes

Assignees
No one assigned
Labels
bug-fix rbd tests wip-dis-testing
Projects
None yet
Milestone
No milestone
3 participants
@idryomov @trociny @chrisphoffman