mgr/dashboard: Add details to the modal which displays the `safe-to-d… #47849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchiaf
requested review from
aaSharma14 and
bryanmontalvan
and removed request for
a team
|
Below, a demo showing all the possible warnings messages for different OSDs:
|
|
Below, the info message in case of the destroy action is safe:
|
|
The CI steps which are failed are not apparently related to the changes included in this PR. |
votdev
requested changes
Sep 1, 2022
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.scss
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.scss
Outdated
Show resolved
Hide resolved
torchiaf
force-pushed
the
fix/37327
branch
2 times, most recently
from
3cd2b47
to
e9bbe2b
Compare
|
jenkins retest this please |
votdev
approved these changes
Sep 8, 2022
torchiaf
force-pushed
the
fix/37327
branch
2 times, most recently
from
9ae6416
to
85990a2
Compare
|
jenkins retest this please |
nizamial09
approved these changes
Sep 16, 2022
| {{ actionDescription }}! {{ message }}</cd-alert-panel> | ||
| class="danger mb-3"> | ||
| <cd-alert-panel type="warning"> | ||
| <ng-container i18n> |
There was a problem hiding this comment.
ng-container is mostly used to hold the structural directives, but here a simple span will suffice, right?
…estroy` result - Add warnings type information in the case of the OSDs are not safe to destroy - Add info type information in the case of the OSDs are safe to destroy Fixes: https://tracker.ceph.com/issues/37327 Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
|
Thanks @torchiaf ! I added the backport for pacific and quincy |
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…estroy` result
Fixes: https://tracker.ceph.com/issues/37327
Signed-off-by: Francesco Torchia francesco.torchia@suse.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows