Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add fixture for setting ip-local-port-range #47855

Closed
wants to merge 2 commits into from

Conversation

tchaikov
Copy link
Contributor

in case we are running out of available ports while performing tests.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai tchaikov@gmail.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

less repeatings this way. also, this change paves the road to adding
a fixture for setting the `net.ipv4.ip_local_port_range`.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
in case we are running out of available ports while performing tests.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
@tchaikov tchaikov marked this pull request as ready for review August 29, 2022 14:54
@tchaikov
Copy link
Contributor Author

tchaikov commented Aug 29, 2022

i investigated the recent "make check" failures (https://jenkins.ceph.com/job/ceph-pull-requests/). it turns out the failures only happen on "huge" boxes where we have 96 cores. and we do run tests using ctest -j$(expr $(nproc) / 2).

this also explains why we can observe the correlation between powerful machines and test failures of https://tracker.ceph.com/issues/57116.

@tchaikov
Copy link
Contributor Author

jenkins test api

@tchaikov
Copy link
Contributor Author

jenkins test make check

3 similar comments
@tchaikov
Copy link
Contributor Author

jenkins test make check

@tchaikov
Copy link
Contributor Author

jenkins test make check

@tchaikov
Copy link
Contributor Author

jenkins test make check

@tchaikov
Copy link
Contributor Author

[ RUN      ] TestMockMigrationHttpClient.OpenCloseHttp
unknown file: Failure
C++ exception with description "bind: Address already in use [system:98]" thrown in SetUp().
[  FAILED  ] TestMockMigrationHttpClient.OpenCloseHttp (77 ms)
[ RUN      ] TestMockMigrationHttpClient.OpenCloseHttps
[       OK ] TestMockMigrationHttpClient.OpenCloseHttps (131 ms)
[ RUN      ] TestMockMigrationHttpClient.OpenHttpsHandshakeFail
unknown file: Failure
C++ exception with description "bind: Address already in use [system:98]" thrown in SetUp().
[  FAILED  ] TestMockMigrationHttpClient.OpenHttpsHandshakeFail (73 ms)
[ RUN      ] TestMockMigrationHttpClient.OpenInvalidUrl
unknown file: Failure
C++ exception with description "bind: Address already in use [system:98]" thrown in SetUp().
[  FAILED  ] TestMockMigrationHttpClient.OpenInvalidUrl (79 ms)

https://jenkins.ceph.com/job/ceph-pull-requests/102697/

still failing. sorry for the noise.

@tchaikov tchaikov closed this Aug 30, 2022
@tchaikov tchaikov deleted the wip-57116 branch September 9, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant