-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] pacific: osd/PeeringState: fix missed recheck_readable from laggy #47899
Conversation
We should not have duplicated OSD ID in `acting`. So the loop would execute once anyway. Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit 9337fa6)
Previously, the first `pg_lease_ack_t` after becoming laggy would not trigger `recheck_readable`. However, every other ack would trigger it. The logic is inverted, causing unnecessarily long laggy PG state. Fixes: 3bb8a72 (osd: requeue ops when PG is no longer laggy) Fixes: https://tracker.ceph.com/issues/53806 Signed-off-by: 胡玮文 <huww98@outlook.com> (cherry picked from commit caeca39)
jenkins test make check |
jenkins test api |
http://pulpito.front.sepia.ceph.com/?branch=wip-yuri5-testing-2022-09-06-1334-pacific Failures, unrelated:
Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We found that this PR has caused a regression. We are reverting the Quincy backport so we can release 17.2.4: #48104
See https://tracker.ceph.com/issues/57546 for more details.
jenkins retest this please |
Let's close this, as there doesn't seem to be a fix to help with the teuthology regression, and Pacific is going EOL. |
backport tracker: https://tracker.ceph.com/issues/56734
backport of #44499
parent tracker: https://tracker.ceph.com/issues/53806
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh