ceph-dencoder: Add global to denc-mod-osd's target_link_libraries #47982

tserong · 2022-09-06T04:01:57Z

Fixes: https://tracker.ceph.com/issues/57390
Signed-off-by: Tim Serong tserong@suse.com

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

Fixes: https://tracker.ceph.com/issues/57390 Signed-off-by: Tim Serong <tserong@suse.com>

tserong · 2022-09-06T04:03:02Z

Note: pacific doesn't need this one. It's only necessary on main and quincy.

tserong · 2022-10-06T01:30:10Z

Ping @tchaikov :-)

tchaikov · 2022-10-08T13:20:32Z

src/tools/ceph-dencoder/CMakeLists.txt

+  erasure_code
+  global)


Suggested change

erasure_code

global)

erasure_code

global-static)

see 4ea38df for the rationales.

I've just tried that, and now ceph-dencoder segfaults:

# ceph-dencoder -h for help Segmentation fault (core dumped) # gdb ceph-dencoder [...] Reading symbols from ceph-dencoder... (No debugging symbols found in ceph-dencoder) (gdb) run Starting program: /usr/bin/ceph-dencoder Missing separate debuginfos, use: zypper install ceph-common-debuginfo-17.0.0-14884.1.x86_64 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". -h for help Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7de1123 in tcmalloc::ThreadCache::ReleaseToCentralCache(tcmalloc::ThreadCache::FreeList*, unsigned int, int) () from /lib64/libtcmalloc.so.4

Note that ceph-dencoder itself links against global, not global-static:

ceph/src/tools/ceph-dencoder/CMakeLists.txt

Lines 97 to 100 in a1bf7f7

target_link_libraries(ceph-dencoder

StdFilesystem::filesystem

global

${DENCODER_EXTRALIBS}

Could that discrepancy cause this? Should I try changing that to global-static as well, or go back to using global for denc-mod-osd?

Just for a test, I tried using global-static on denc-mod-osd as above, and switched global to global-static in ceph-dencoder like so:

--- ceph-17.0.0-14883-gc49b81c7d61.orig/src/tools/ceph-dencoder/CMakeLists.txt +++ ceph-17.0.0-14883-gc49b81c7d61/src/tools/ceph-dencoder/CMakeLists.txt @@ -97,7 +97,7 @@ target_compile_definitions(ceph-dencoder target_link_libraries(ceph-dencoder StdFilesystem::filesystem - global + global-static ${DENCODER_EXTRALIBS} cls_log_client cls_version_client

That fixes the segfault, but now I've got another undefined symbol (this time in denc-mod-common):

# ceph-dencoder failed to dlopen("/usr/lib64/ceph/denc/denc-mod-common.so"): /usr/lib64/ceph/denc/denc-mod-common.so: undefined symbol: _ZTI7Message -h for help

Based on these tests, I think we just need to use global, not global-static, unless there's some other change(s) necessary in addition to the above.

@tserong hi Tim, sorry. i didn't look into the linkage of ceph-dencoder itself. agreed, it it links against global-static, we should not link denc-mod-* against it again. it'd violate the ODR (one definition rule). but after a second thought, i think we need to drop global from ceph-dencoder's linked libraries list. BTW, sorry for the latency. i was in a "power saver mode" last month.

#48418 is created to implement this proposal.

tchaikov

@tserong the global linkage is likely to be pulled in by mon and osd which reference ErasureCodePluginRegistry::instance(). but i still don't understand why this makes it a dependency. as the function using this symbol is not used by ceph-dencoder or any of its denc-mod-* plugins. guess LTO thinks different than I do..

but i don't want to block you because of my incompetence. from the test result and your reasoning, this change makes sense.

tserong · 2022-10-11T01:49:57Z

BTW, sorry for the latency. i was in a "power saver mode" last month.

No problem!

but i don't want to block you because of my incompetence. from the test result and your reasoning, this change makes sense.

Incompetence? Nah man, you still know more about this stuff than me :-)

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See ceph#47982 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p1 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See ceph#47982 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See ceph#47982 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git --exclude=test --exclude=tests . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf patch -p1 -d src/spdk < SPDK_CONFIG_HAVE_ARC4RANDOM.patch patch -p3 -d src/spdk < spdk_top-string-format.patch tar zcvf ../ceph_17.2.5.orig.tar.gz --exclude=.git . debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-dist mv ceph-17.2.5-1*.tar.bz ../ceph_17.2.5-1.tar.bz debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-dist mv ceph-17.2.5-1*.tar.bz2 ../ceph_17.2.5.orig.tar.bz2 git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf debuild -uc -us cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{bz2,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-debs.sh mv ceph-17.2.5-1*.tar.bz2 ../ceph_17.2.5.orig.tar.bz2 debuild -uc -us -i cp ceph.spec ../ceph_17.2.5-1.spec mv ../*ceph*17.2.5*.{bz2,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf ../*ceph*17.2.5*.* See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-debs.sh cp ceph.spec /tmp/release/Ubuntu/WORKDIR/ceph_17.2.5-1.spec mv /tmp/release/Ubuntu/WORKDIR/*ceph*17.2.5*.{bz2,xz,spec,dsc} /osc/home\:alvistack/ceph-ceph-17.2.5/ rm -rf /tmp/release/Ubuntu/WORKDIR See http://archive.ubuntu.com/ubuntu/pool/main/c/ceph/ceph_17.2.5-0ubuntu2.debian.tar.xz See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See ceph#47982 See spdk/spdk#2637 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-debs.sh cp /tmp/release/Ubuntu/WORKDIR/*ceph*17.2.7*.{bz2,xz,dsc} /osc/home\:alvistack/ceph-ceph-17.2.7/ cp ceph.spec /osc/home\:alvistack/ceph-ceph-17.2.7/ceph_17.2.7-1.spec cp ceph.rpmlintrc /osc/home\:alvistack/ceph-ceph-17.2.7/ cp debian/patches/*.patch /osc/home\:alvistack/ceph-ceph-17.2.7/ cp _constraints /osc/home\:alvistack/ceph-ceph-17.2.7/ rm -rf /tmp/release/Ubuntu/WORKDIR See spdk/spdk#2637 See ceph#47712 See ceph#47982 See ceph#53698 See https://tracker.ceph.com/issues/56610 See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://packages.ubuntu.com/source/lunar/ceph Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-debs.sh cp /tmp/release/Ubuntu/WORKDIR/*ceph*16.2.14*.{bz2,xz,dsc} /osc/home\:alvistack/ceph-ceph-16.2.14/ cp ceph.spec /osc/home\:alvistack/ceph-ceph-16.2.14/ceph_16.2.14-1.spec cp ceph.rpmlintrc /osc/home\:alvistack/ceph-ceph-16.2.14/ cp debian/patches/*.patch /osc/home\:alvistack/ceph-ceph-16.2.14/ cp _constraints /osc/home\:alvistack/ceph-ceph-16.2.14/ rm -rf /tmp/release/Ubuntu/WORKDIR See spdk/spdk#2637 See ceph#47712 See ceph#47982 See https://tracker.ceph.com/issues/56610 See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://packages.ubuntu.com/source/lunar/ceph Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>

git clean -xdf git submodule sync --recursive git submodule update --recursive --init git submodule foreach --recursive git checkout -- . git submodule foreach --recursive git clean -xdf ./make-debs.sh cp /tmp/release/Ubuntu/WORKDIR/*ceph*15.2.17*.{bz2,xz,dsc} /osc/home\:alvistack/ceph-ceph-15.2.17/ cp ceph.spec /osc/home\:alvistack/ceph-ceph-15.2.17/ceph_15.2.17-1.spec cp ceph.rpmlintrc /osc/home\:alvistack/ceph-ceph-15.2.17/ cp debian/patches/*.patch /osc/home\:alvistack/ceph-ceph-15.2.17/ cp _constraints /osc/home\:alvistack/ceph-ceph-15.2.17/ rm -rf /tmp/release/Ubuntu/WORKDIR See spdk/spdk#2637 See ceph#47712 See ceph#47982 See https://tracker.ceph.com/issues/56610 See https://build.opensuse.org/package/show/filesystems:ceph:quincy:upstream/ceph See https://src.fedoraproject.org/rpms/ceph/tree/rawhide See https://packages.ubuntu.com/source/lunar/ceph Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>