Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephadm: consider stdout to get container version #48118

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

s0nea
Copy link
Member

@s0nea s0nea commented Sep 15, 2022

Fixes: https://tracker.ceph.com/issues/57558
Signed-off-by: Tatjana Dehler tdehler@suse.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@s0nea s0nea requested a review from a team as a code owner September 15, 2022 13:41
Copy link
Contributor

@mgfritch mgfritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this now reports the correct version when using the the upstream quay.io/prometheus/node-exporter:v0.18.1 and quay.io/prometheus/alertmanager:v0.23.0 images

@s0nea
Copy link
Member Author

s0nea commented Sep 15, 2022

jenkins test make check

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Fixes: https://tracker.ceph.com/issues/57558
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
@s0nea
Copy link
Member Author

s0nea commented Sep 21, 2022

jenkins test make check arm64

@s0nea
Copy link
Member Author

s0nea commented Sep 22, 2022

jenkins test dashboard cephadm

@adk3798
Copy link
Contributor

adk3798 commented Sep 22, 2022

https://pulpito.ceph.com/adking-2022-09-21_23:09:11-orch:cephadm-wip-adk-testing-2022-09-21-1718-distro-default-smithi/

1 failure, seems to be a random infra one setting up a package before the test. Reran the failed test 3 times an they all passed
https://pulpito.ceph.com/adking-2022-09-22_12:08:43-orch:cephadm-wip-adk-testing-2022-09-21-1718-distro-default-smithi/

So basically a green run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants