quincy: os/bluestore: use direct write in BlueStore::_write_bdev_label #48279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AArch64 with kernel page size 64K, it occurs occasionally "OSD::init(): unable to read osd superblock" when deploying osd. As bluestore use direct write to write the superblock at 0x2000~1000 and BlueStore::_write_bdev_label use buffer write to write label at 0x0~1000, The OS flush the buffer write algined to page size, it will overwrite the superblock(0x2000~1000). Use driect write to avoid overwriting the superblock. Fixes: https://tracker.ceph.com/issues/57537 Signed-off-by: luo rixin <luorixin@huawei.com> (cherry picked from commit afdb5e4)
|
jenkins retest this please |
|
jenkins test make check |
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
aclamk
approved these changes
Jul 4, 2023
|
jenkins test docs |
|
jenkins test docs |
|
Hey @ifed01, a new failure reproduced twice in this batch: https://tracker.ceph.com/issues/62401 There were 3 bluestore PRs in the batch, so I will leave a similar message on all of them, as I'm not sure which one could be responsible. Can you take a look and see if it's related? If not, the test results were otherwise clean. Rados suite review here: https://tracker.ceph.com/projects/rados/wiki/QUINCY#httpstrellocomcw1wxAcJO1814-wip-yuri8-testing-2023-07-24-0819-quincy |
This was referenced Aug 10, 2023
|
Feel free to merge if the above failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AArch64 with kernel page size 64K, it occurs occasionally "OSD::init(): unable to read osd superblock" when deploying osd. As bluestore use direct write to write the superblock at 0x2000
1000 and BlueStore::_write_bdev_label use buffer write to write label at 0x01000, The OS flush the buffer write algined to page size, it will overwrite the superblock(0x2000~1000). Use driect write to avoid overwriting the superblock.Fixes: https://tracker.ceph.com/issues/57688
Signed-off-by: luo rixin luorixin@huawei.com
(cherry picked from commit afdb5e4)
Signed-off-by: Igor Fedotov ifedotov@croit.io
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows