quincy: rgw: x-amz-date change breaks certain cases of aws sig v4. #48312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs-qa |
Once upon a time, x-amz-date strings were in rfc 2616 format, and most s3 clients are written to make this style of timestamp. The current protocol standard specifies iso 8601 timestamps (yyyymmddThhmmssZ), and client libraries are changing to use this new format. This change does two things: firstly, if the date parse fails, it logs the actual offending timestamp for later analysis. Secondly, if rfc 2616 fails, it tries iso 8601. The new timestamp is tried secondarily, because that lgoic also emits a (less useful) error message, which should not be spamnificated for valid rfc 2616 timestamps. Fixes: https://tracker.ceph.com/issues/57094 Signed-off-by: Marcus Watts <mwatts@redhat.com> (cherry picked from commit 70ba760)
k0ste
force-pushed
the
wip-57196-quincy
branch
from
7eadd52
to
a0e92d3
Compare
|
jenkins retest |
smanjara
approved these changes
Feb 21, 2023
|
jenkins test api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/57196
backport of #47547
parent tracker: https://tracker.ceph.com/issues/57094
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh