qa/workunits/rbd: merge journal and snapshot test scripts #48508
Conversation
|
@idryomov will it be possible for you to schedule the lab tests for this PR, please? Thanks! |
There was a problem hiding this comment.
Overall great job, there was a bunch to get right and it looks like you did.
I have two additional improvements:
-As this change deletes rbd_mirror_snapshot.sh and rbd_mirror_journal.sh and combines into rbd_mirror.sh can you change the yaml files for integration testing to use this new script? For example: ./ceph/qa/suites/rbd/mirror/workloads/rbd-mirror-workunit-config-key.yaml
-rbd_mirror_helpers.sh comments reference one of the old scripts, I'd recommend changing it to reference the new one.
|
@idryomov @chrisphoffman thanks for the review, addressed your review comments now. |
|
jenkins test windows |
pkalever
force-pushed
the
rbd-tests
branch
2 times, most recently
from
23e6966
to
2f46ec2
Compare
|
@idryomov isn't this ready for a merge? |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
@idryomov anything pending on this? |
|
Latest version test run results: |
|
Please squash everything into the first commit: the other two commits don't stand on their own because |
|
Latest version test run results: |
The idea is to avoid the maintenance of duplicate code in both the journal and snapshot test scripts. Usage: RBD_MIRROR_MODE=journal rbd_mirror.sh Use environment variable RBD_MIRROR_MODE to set the mode Available modes: snapshot | journal Fixes: https://tracker.ceph.com/issues/54312 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
Latest version test run results: |
The idea is to avoid the maintenance of duplicate code in both the journal and snapshot test scripts.
Usage:
rbd_mirror.sh [<mode>]
Available modes: snapshot or journal
You can also use environment variable RBD_MIRRIR_MODE to set the mode
Fixes: https://tracker.ceph.com/issues/54312
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows