Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: doc/radosgw: refine "notification reliability" #48530

Merged

Conversation

zdover23
Copy link
Contributor

@zdover23 zdover23 commented Oct 18, 2022

This commit refines the English in the "Notification Reliability" section of the notifications.rst page (the "Bucket Notifications" page). I have also added signposting structure.

Co-authored-by: Anthony D'Atri anthony.datri@gmail.com
Co-authored-by: Yuval Lifshitz ylifshit@redhat.com

Signed-off-by: Zac Dover zac.dover@gmail.com
(cherry picked from commit 8f7b57f)

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

This commit refines the English in the "Notification Reliability"
section of the notifications.rst page (the "Bucket Notifications"
page). I have also added signposting structure.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Yuval Lifshitz <ylifshit@redhat.com>

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 8f7b57f)
@zdover23 zdover23 requested a review from a team as a code owner October 18, 2022 15:04
@github-actions github-actions bot added this to the pacific milestone Oct 18, 2022
@zdover23
Copy link
Contributor Author

jenkins retest this please

@zdover23
Copy link
Contributor Author

Note to posterity: the pr-triage check failed when I first raised this PR. That's why I asked Jenkins to retest it. But the pr-triage check isn't a test that's required for documentation, so I'm proceeding with the merge.

@zdover23 zdover23 merged commit d6ef237 into ceph:pacific Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants