Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: skip isa tests if the plugin is not available #4888

Merged
merged 3 commits into from Jun 8, 2015
Merged

tests: skip isa tests if the plugin is not available #4888

merged 3 commits into from Jun 8, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2015

Return 0 if the erasure code *plugin* is available, 1 otherwise.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
Instead of the local plugin_exists helper that does the same.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost added bug-fix tests labels Jun 7, 2015
@ghost ghost assigned tchaikov Jun 7, 2015
@ghost
Copy link
Author

ghost commented Jun 7, 2015

building wip-11905-test-isa in gitbuilders

@ghost
Copy link
Author

ghost commented Jun 7, 2015

@tchaikov I overlooked the error that was in the i386 gitbuilder although I scheduled the gitbuilders to verify the commit that introduces the problem. It's an interesting combination of "let's be careful" and "let's ignore the error we were looking for". I did not look at the error because the tarbal gitbuilder were in such a poor state, but that's not really an excuse.

@ghost
Copy link
Author

ghost commented Jun 7, 2015

tchaikov added a commit that referenced this pull request Jun 8, 2015
tests: skip isa tests if the plugin is not available

Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit 66f3b19 into ceph:master Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants